This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7eb046624f2a: Prefer `getCurrentFileOrBufferName` in
`FrontendAction::EndSourceFile` (authored by JohnTitor).
Repository:
rG LLVM Github Monorepo
JohnTitor added a comment.
Alright, let's go ahead then.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127509/new/
https://reviews.llvm.org/D127509
___
cfe-commits mailing list
tbaeder accepted this revision.
tbaeder added a comment.
This revision is now accepted and ready to land.
Those are all libomp tests, I doubt they are related. I think it's fine to just
push this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
JohnTitor added a comment.
I've re-triggered it several times but it shows the same failure, maybe they're
valid?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127509/new/
https://reviews.llvm.org/D127509
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127509/new/
https://reviews.llvm.org/D127509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder added a comment.
LGTM but can you try re-running the pre-commit CI?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127509/new/
https://reviews.llvm.org/D127509
___
cfe-commits mailing list
JohnTitor created this revision.
Herald added a project: All.
JohnTitor requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
`getCurrentFile` here causes an assertion on some condition.
`getCurrentFileOrBufferName` is preferrable instead.
