[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hubert.reinterpretcast added a comment. In D127544#3609393 , @hctim wrote: > I see that the clang-ppc64le-linux bot is green with the second attempt > (https://lab.llvm.org/buildbot/#/builders/105/builds/27200). Please let me > know if you have further

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added a comment. I see that the clang-ppc64le-linux bot is green with the second attempt (https://lab.llvm.org/buildbot/#/builders/105/builds/27200). Please let me know if you have further issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added a comment. In D127544#3609343 , @hubert.reinterpretcast wrote: > In D127544#3609335 , @hctim wrote: > >> Sent fadc98b06befb674fa47da4f3d8606bf61bed681 >>

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hubert.reinterpretcast added a comment. In D127544#3609335 , @hctim wrote: > Sent fadc98b06befb674fa47da4f3d8606bf61bed681 > to > fix-forward. I thought `*-registered-target` is

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added a comment. Sent fadc98b06befb674fa47da4f3d8606bf61bed681 to fix-forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127544/new/ https://reviews.llvm.org/D127544

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added a comment. In D127544#3609312 , @hubert.reinterpretcast wrote: > This is causing "unsupported architecture" errors on bots. Looking, I see this on the sanitizer-ppc64 bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hubert.reinterpretcast added a comment. From the content of this patch, it probably is `llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp`: switch (TargetTriple.getArch()) { case Triple::x86_64: // The signal handler will find the data address in rdi. Asm = InlineAsm::get(

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hubert.reinterpretcast added a comment. This is causing "unsupported architecture" errors on bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127544/new/ https://reviews.llvm.org/D127544 ___

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfaf5e0ec737a: Add no_sanitize(hwaddress) (and memtag, but thats a no-op). (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! The debian failures look like precommit CI is in a broken state again, but have nothing to do with your patch. Comment at:

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim updated this revision to Diff 437734. hctim marked 2 inline comments as done. hctim added a comment. Create test input files rather than synthesizing on the fly, fix tests on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127544/new/

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim marked 2 inline comments as done. hctim added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8849 break; - // HLSL attributes: aaron.ballman wrote: > hctim wrote: > > aaron.ballman wrote: > > > Spurious whitespace change? > >

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

aaron.ballman added a comment. Btw, precommit CI caught a failure: FAIL: Clang :: CodeGen/hwasan-globals.cpp (4495 of 15547) TEST 'Clang :: CodeGen/hwasan-globals.cpp' FAILED Script: -- : 'RUN: at line 1'; echo "int extra_global;" >

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8849 break; - // HLSL attributes: hctim wrote: > aaron.ballman wrote: > > Spurious whitespace change? > unfortunately there's no way in my editor to trim trailing

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8849 break; - // HLSL attributes: aaron.ballman wrote: > Spurious whitespace change? unfortunately there's no way in my editor to trim trailing whitespace only on changed lines

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim updated this revision to Diff 437355. hctim marked 6 inline comments as done. hctim added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127544/new/ https://reviews.llvm.org/D127544 Files: clang/lib/Sema/SemaDeclAttr.cpp

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

aaron.ballman added a comment. Thank you for this, can you also add a release note for the fix? Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8849 break; - // HLSL attributes: Spurious whitespace change? Comment at:

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim created this revision. hctim added a reviewer: pcc. Herald added a reviewer: aaron.ballman. Herald added a subscriber: Enna1. Herald added a project: All. hctim requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits.