[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

2022-06-20 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. In D128098#3594637 , @tschuett wrote: > There are now several JSON fragments per file? Previously, there was one > fragment per file. > > This will fail now: > https://sarcasm.github.io/notes/dev/compilation-database.html#cl

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

2022-06-19 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. There are now several JSON fragments per file? Perviously there was one fragment per file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128098/new/ https://reviews.llvm.org/D128098 __

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

2022-06-17 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/Driver/compilation_database_multiarch.c:15 // CHECK-NEXT: { "directory": "{{.*}}", "file": "{{.*}}", "output": "[[OUTPUT_ARM64:.*]]", "arguments": [{{.*}}, "-o", "[[OUTPUT_ARM64]]", {{.*}} "--target=arm64-apple-macosx12.0.0

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

2022-06-17 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128098/new/ https://reviews.llvm.org/D128098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

2022-06-17 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92c6ffa14cde: [clang][driver] Ensure we don't accumulate entries in -MJ files (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHA

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

2022-06-17 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. Thanks for the review! Comment at: clang/test/Driver/compilation_database_multiarch.c:15 // CHECK-NEXT: { "directory": "{{.*}}", "file": "{{.*}}", "output": "[[OUTPUT_ARM64:.*]]", "arguments": [{{.*}}, "-o", "[[OUTPUT_ARM64]]", {{.*}} "--target=

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

2022-06-17 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. LGTM. Comment at: clang/test/Driver/compilation_database_multiarch.c:15 // CHECK-NEXT: { "directory": "{{.*}}", "file": "{{.*}}", "o

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

2022-06-17 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 added a reviewer: egorzhdan. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Previously, each job would overwrite the -MJ file. This didn't q