[PATCH] D128127: [Driver][OpenBSD] Specify linker emulations

2022-06-19 Thread Brad Smith via Phabricator via cfe-commits
brad added a comment. In D128127#3594784 , @MaskRay wrote: > Then maybe this is not needed. Ok, I have had a diff sitting around for awhile but questioned it's usefulness since it has not been necessary to date. Repository: rG LLVM Github Monorepo

[PATCH] D128127: [Driver][OpenBSD] Specify linker emulations

2022-06-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Then maybe this is not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128127/new/ https://reviews.llvm.org/D128127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128127: [Driver][OpenBSD] Specify linker emulations

2022-06-19 Thread Brad Smith via Phabricator via cfe-commits
brad added a comment. In D128127#3594464 , @MaskRay wrote: > Is the `-m` value useful for OpenBSD? If not, it's perhaps not useful to have > this logic. We have been running without so far and do not use multi-lib archs. Repository: rG LLVM Github

[PATCH] D128127: [Driver][OpenBSD] Specify linker emulations

2022-06-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Is the `-m` value useful for OpenBSD? If not, it's perhaps not useful to have this logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128127/new/ https://reviews.llvm.org/D128127

[PATCH] D128127: [Driver][OpenBSD] Specify linker emulations

2022-06-18 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 438173. brad added a comment. Further tweak tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128127/new/ https://reviews.llvm.org/D128127 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp

[PATCH] D128127: [Driver][OpenBSD] Specify linker emulations

2022-06-18 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 438160. brad added a comment. Update tests to conform to recent style changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128127/new/ https://reviews.llvm.org/D128127 Files:

[PATCH] D128127: [Driver][OpenBSD] Specify linker emulations

2022-06-18 Thread Brad Smith via Phabricator via cfe-commits
brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added subscribers: luke957, StephenFan, s.egerton, simoncook, fedor.sergeev. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: pcwang-thead. Have the