kerbowa marked an inline comment as done.
kerbowa added inline comments.
Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:314
+
+bool SchedGroup::isFull() const {
+ return MaxSize && Collection.size() >= *MaxSize;
uabelho wrote:
> Compiling with gcc, I get
uabelho added inline comments.
Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:314
+
+bool SchedGroup::isFull() const {
+ return MaxSize && Collection.size() >= *MaxSize;
Compiling with gcc, I get a warning that this function is unused.
I'm wondering, ther
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf5b21680d122: [AMDGPU] Add amdgcn_sched_group_barrier
builtin (authored by kerbowa).
Changed prior to commit:
https://reviews.llvm.org/D128158?vs=
jrbyrnes added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128158/new/
https://reviews.llvm.org/D128158
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
kerbowa updated this revision to Diff 445965.
kerbowa added a comment.
Fix some bugs. Add better pipeline fitting. Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128158/new/
https://reviews.llvm.org/D128158
Files:
clang/include/
arsenm added inline comments.
Comment at: clang/test/SemaOpenCL/builtins-amdgcn-error.cl:70
+{
+ __builtin_amdgcn_sched_group_barrier(x, 0, 1); // expected-error {{argument
to '__builtin_amdgcn_sched_group_barrier' must be a constant integer}}
+}
Test error for
jrbyrnes added a comment.
Hey Austin -- I like the removal of canAddMIs. In the original design, I was
leaving open the possibility for users to pass in canAddMIs rather than a mask
/ SchedGroup name, but it looks like this isn't the direction we're going, and
the classification functions defin
kerbowa added a comment.
Somewhat WIP needs more tests and cleanup. Posted for dependent work.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128158/new/
https://reviews.llvm.org/D128158
___
cfe-commits m
kerbowa created this revision.
kerbowa added reviewers: rampitec, jrbyrnes, vangthao95, arsenm.
Herald added subscribers: kosarev, jsilvanus, foad, hiraditya, t-tye, tpr,
dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
Herald added a project: All.
kerbowa requested review of this revision.
Herald
