[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9343ec861a2e: [clang-tidy] Adding the missing handling of noreturn attributes for Obj-C… (authored by ziqingluo-90).

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

NoQ accepted this revision. NoQ added a comment. Still looks good to me, let's commit! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128314/new/ https://reviews.llvm.org/D128314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 447854. ziqingluo-90 added a comment. The `callee` ASTMatcher overloading patch has landed in LLVM repo. I update this patch to use `callee` for matching objective-C message callee methods. CHANGES SINCE LAST ACTION

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

NoQ accepted this revision. NoQ added a comment. Thanks! Good to go after the matchers patch is committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128314/new/ https://reviews.llvm.org/D128314 ___

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 added a comment. In D128314#3635861 , @njames93 wrote: > Sorry to do this again, but could this be split up again, one patch for the > new matcher and the tests associated with it, then another for the actual bug > fix. > Also cc @klimek

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

njames93 added a subscriber: klimek. njames93 added a comment. Sorry to do this again, but could this be split up again, one patch for the new matcher and the tests associated with it, then another for the actual bug fix. Also cc @klimek as he is the code owner of ASTMatchers Repository: rG

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

NoQ added a comment. Sounds great! I have a nitpick but other than that I think this fix is good to go. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3841 +/// matches if ObjCMessageExpr's callee declaration matches +/// It looks like

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 added a comment. In D128314#3605588 , @NoQ wrote: > Nice! > > There's usually some bureaucracy when creating new matchers, i.e. there > should be documentation and unittests covering them. I have added a unit test and auto-generated

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 441832. ziqingluo-90 added a comment. adding a unit test for the ASTMatcher `objcMessageCallee` added in ASTMatcher.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128314/new/

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 441816. ziqingluo-90 added a comment. I saw @aaron.ballman 's comment "//We typically don't add AST matchers until we have a need for them to be used in-tree (ASTMatchers.h is already really expensive to parse; adding matchers for everything possible

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 439549. ziqingluo-90 added a comment. adjusted my changes with respect to the recent file structure changes in clang-tidy test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128314/new/ https://reviews.llvm.org/D128314 Files:

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 439545. ziqingluo-90 removed reviewers: rsundahl, yln, kubamracek, krispy1994, jkorous, delcypher, chrisdangelo, thetruestblue, dcoughlin. ziqingluo-90 added a comment. rebased with the latest main's HEAD CHANGES SINCE LAST ACTION

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs,

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

NoQ added a comment. Nice! There's usually some bureaucracy when creating new matchers, i.e. there should be documentation and unittests covering them. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5099 +/// matches a FunctionType if the type includes the GNU no

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 439132. ziqingluo-90 retitled this revision from "[Clang-tidy] Fixing bugs in clang-tidy infinite-loop checker" to "[Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker". ziqingluo-90 edited the summary of this revision. ziqingluo-90 added a