[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c106c93eb68: [clangd] Change the url for clang-tidy check documentation (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128379/new/

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks a lot, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128379/new/ https://reviews.llvm.org/D128379

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 updated this revision to Diff 449046. njames93 added a comment. Revert to first version, just so we can sort out the 15.X branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128379/new/ https://reviews.llvm.org/D128379 Files:

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

kadircet added a comment. sorry this has slipped through. since we're going to backport it, let's make it minimal and always point to in-progress release notes (so sorry for reverting back to original version of the patch). i think having clangd point to versioned docs would be much nicer, but

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 added a comment. What's the plan with this, a fix wouod likely need to be backportsd for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128379/new/ https://reviews.llvm.org/D128379 ___

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 updated this revision to Diff 441499. njames93 added a comment. Changed to only use the major version. If this still seems too flaky, happy to go back to just linking to the in progress release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 added a comment. In D128379#3622286 , @sammccall wrote: > In D128379#3622128 , @sammccall > wrote: > >> Hmm, this version looks complicated to me. >> And also fragile: downstream we have

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

sammccall added a comment. In D128379#3622128 , @sammccall wrote: > Hmm, this version looks complicated to me. > And also fragile: downstream we have CLANG_VERSION_STRINGs that don't match > upstream, Apple has their own versioning scheme, linux distros

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

sammccall added a comment. Hmm, this version looks complicated to me. And also fragile: downstream we have CLANG_VERSION_STRINGs that don't match upstream, Apple has their own versioning scheme, linux distros tend to do things like `6.0.1~ubuntu3`... Let me sync with @kadircet Repository:

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 requested review of this revision. njames93 added a comment. Any issues with this now for getting correct version? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128379/new/ https://reviews.llvm.org/D128379

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 updated this revision to Diff 441352. njames93 added a comment. Fix lit cfg typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128379/new/ https://reviews.llvm.org/D128379 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 updated this revision to Diff 441351. njames93 added a comment. Herald added subscribers: ormris, mgorny. Emit documentation links for the version of clangd built. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128379/new/

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 added a comment. Pointing the documentation links based on build configuration and version definitely makes sense as evolving checks could easily confuse users. Guess the idea is snapshot builds will use the in progress release notes, and release builds can point to the actual release

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

kadircet added a comment. luckily this document links were introduced only recently, hence they didn't make it to clangd-14, but they'll start being around from clangd-15 and such changes will be breaking all the links in existing clangd's. i wonder if we should actually point these at

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:928 +std::tie(Module, Check) = Name.split('-'); +assert(!Module.empty() && !Check.empty()); +return {("https://clang.llvm.org/extra/clang-tidy/checks/; + Module + "/" +

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/Diagnostics.cpp:928 +std::tie(Module, Check) = Name.split('-'); +assert(!Module.empty() && !Check.empty()); +

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: