This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG51f1ae52b0c9: [clangd] Add new IncludeDirective to
IncludeHeaderWithReferences (authored by dgoldman).
Changed prior to commit:
https://reviews.ll
dgoldman updated this revision to Diff 480513.
dgoldman marked 2 inline comments as done.
dgoldman added a comment.
Update test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128457/new/
https://reviews.llvm.org/D128457
Files:
clang-tools-extra/c
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang/unittests/Tooling/HeaderAnalysisTest.cpp:69
+ #include "foo.h"
+#import "NSFoo.h"
+
indentation
C
dgoldman updated this revision to Diff 480465.
dgoldman marked 4 inline comments as done.
dgoldman added a comment.
Fixes + hopefully proper diffbase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128457/new/
https://reviews.llvm.org/D128457
Files:
kadircet added a comment.
it feels like rebasing went wrong. changes from 2 unrelated patches seem to be
part of this one now. can you make sure this patch only contains the delta for
symbolcollector/clangd pieces?
Comment at: clang-tools-extra/clangd/Headers.h:50
+ /// The
dgoldman updated this revision to Diff 479664.
dgoldman added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128457/new/
https://reviews.llvm.org/D128457
Files:
clang-tools-extra/clangd/CodeComplete.cpp
clang-tools-extra/clang
dgoldman updated this revision to Diff 479066.
dgoldman added a comment.
Herald added a project: clang.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128457/new/
https://reviews.llvm.org/D128457
Files:
clang-tools-extra/clangd/CodeComplet
dgoldman updated this revision to Diff 479024.
dgoldman marked 6 inline comments as done.
dgoldman added a comment.
Fixes for review
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128457/new/
https://reviews.llvm.org/D128457
Files:
clang-tools-ex
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/Headers.cpp:237
for (const auto &Include : Includes)
-Headers.push_back(Include.IncludeHeader);
+if (Include.SupportedDirectives & clang::clangd::Symbol::Include)
+ Headers.push_back(Include.Incl
dgoldman updated this revision to Diff 476220.
dgoldman marked 10 inline comments as done.
dgoldman added a comment.
Fixes for review
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128457/new/
https://reviews.llvm.org/D128457
Files:
clang-tools-e
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/SourceCode.cpp:1241
+ !HeaderInfo.hasFileBeenImported(FE) &&
+ (FID != SM.getMainFileID() || !fileContainsImports(FID, SM)))
return false;
can you put a comment here saying `any h
dgoldman updated this revision to Diff 475180.
dgoldman added a comment.
Run clang format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128457/new/
https://reviews.llvm.org/D128457
Files:
clang-tools-extra/clangd/SourceCode.cpp
clang-tools-ext
dgoldman updated this revision to Diff 474571.
dgoldman marked an inline comment as done.
dgoldman added a comment.
Fix serialization and isSelfContainedHeader
- Keep serialization as a single var uint32
- Keep old imported logic in isSelfContainedHeader in addition to a new check
for import lin
dgoldman marked 4 inline comments as done.
dgoldman added a comment.
Also LMK if you want more in this change (such as a flag to control it, just
not sure where it should live + what it should be called).
Comment at: clang-tools-extra/clangd/index/Symbol.h:116
+/// this he
dgoldman updated this revision to Diff 473347.
dgoldman marked an inline comment as done.
dgoldman added a comment.
Fixes for review
- Swap over IncludeType to IncludeDirective and update the protos accordingly
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.l
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/Symbol.h:93
+Import = 2,
+ };
+
you can use `LLVM_MARK_AS_BITMASK_ENUM` and relevant magic to implement bitwise
operators on the type (see llvm-project/llvm/include/llvm/ADT/BitmaskE
dgoldman updated this revision to Diff 470868.
dgoldman added a comment.
Change IncludeTypes to be a bitset
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128457/new/
https://reviews.llvm.org/D128457
Files:
clang-tools-extra/clangd/index/Merge.cp
dgoldman created this revision.
dgoldman added a reviewer: kadircet.
Herald added subscribers: wenlei, usaxena95, arphaman.
Herald added a project: All.
dgoldman requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-ext
18 matches
Mail list logo
