[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added a comment. I understand your frustration with the regression, but let’s try to constructive. We all care about quality and we’re all working hard to do the best we can. In D128462#3794868 , @kadircet wrote: > My main complaint here's

[PATCH] D128462: [HLSL] add -I option for dxc mode.

kadircet added a comment. In D128462#3793266 , @beanz wrote: > I think we had no expectation that DXC-mode would be supported by the tooling > APIs at this point. Right, and as I mentioned in my previous comments this is completely fine, at least in

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added a comment. I think we had no expectation that DXC-mode would be supported by the tooling APIs at this point. For context, DXC is the HLSL compiler that is based on clang-3.7. The DXC mode provides interface compatibility with it. DXC doesn't work with any of the clang tooling

[PATCH] D128462: [HLSL] add -I option for dxc mode.

kadircet added a comment. BTW, I am not sure when the new DXC driver mode was introduced but ATM it isn't properly handled by clang-tooling APIs, especially clangd. As the logic there wasn't updated accordingly, and it also resulted in regressions for clang-cl mode. I've sent out

[PATCH] D128462: [HLSL] add -I option for dxc mode.

kadircet added a subscriber: jansvoboda11. kadircet added inline comments. Comment at: clang/include/clang/Driver/Options.td:6362 -def cl_Group : OptionGroup<"">, Flags<[CLOption]>, +def cl_Group : OptionGroup<"">, Flags<[CLDXCOption]>, HelpText<"CL.EXE COMPATIBILITY

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6362 -def cl_Group : OptionGroup<"">, Flags<[CLOption]>, +def cl_Group : OptionGroup<"">, Flags<[CLDXCOption]>, HelpText<"CL.EXE COMPATIBILITY OPTIONS">; kadircet wrote: > i am

[PATCH] D128462: [HLSL] add -I option for dxc mode.

kadircet added inline comments. Comment at: clang/include/clang/Driver/Options.td:6362 -def cl_Group : OptionGroup<"">, Flags<[CLOption]>, +def cl_Group : OptionGroup<"">, Flags<[CLDXCOption]>, HelpText<"CL.EXE COMPATIBILITY OPTIONS">; i am failing to

[PATCH] D128462: [HLSL] add -I option for dxc mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa73a84c44753: [HLSL] add -I option for dxc mode. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/ https://reviews.llvm.org/D128462 ___

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 445967. python3kgae added a comment. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang-tools-extra. Fix test fail in clangd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 444834. python3kgae added a comment. Remove DXCJoinedOrSeparateConflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/ https://reviews.llvm.org/D128462 Files:

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 444830. python3kgae marked an inline comment as done. python3kgae added a comment. Merge change from Chris. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/ https://reviews.llvm.org/D128462

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added a comment. This change works and avoids the duplicated group. The duplicated group results in the help spew duplicating the group heading, which is undesirable. diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Options.td:6318 + HelpText<"CL.EXE COMPATIBILITY OPTIONS">; + def cl_compile_Group : OptionGroup<"">, beanz wrote: > Do we need this group

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6318 + HelpText<"CL.EXE COMPATIBILITY OPTIONS">; + def cl_compile_Group : OptionGroup<"">, Do we need this group or can it just be `cl_Group`? Repository: rG LLVM Github

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 444803. python3kgae marked an inline comment as done. python3kgae added a comment. Add CLDXCOption flag and share option with CL mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6824 +class DXCJoinedOrSeparateConflict : Option<["--", "/", "-"], name, + KIND_JOINED_OR_SEPARATE>, Group, Flags<[DXCOption, NoXarchOption]>; python3kgae wrote: > beanz wrote: >

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Options.td:6824 +class DXCJoinedOrSeparateConflict : Option<["--", "/", "-"], name, + KIND_JOINED_OR_SEPARATE>, Group, Flags<[DXCOption, NoXarchOption]>;

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6824 +class DXCJoinedOrSeparateConflict : Option<["--", "/", "-"], name, + KIND_JOINED_OR_SEPARATE>, Group, Flags<[DXCOption, NoXarchOption]>; python3kgae wrote: > pow2clk wrote:

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Options.td:6824 +class DXCJoinedOrSeparateConflict : Option<["--", "/", "-"], name, + KIND_JOINED_OR_SEPARATE>, Group, Flags<[DXCOption, NoXarchOption]>;

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 13. python3kgae marked 3 inline comments as done. python3kgae added a comment. Update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/ https://reviews.llvm.org/D128462 Files:

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6851 Group, Flags<[DXCOption, NoXarchOption]>, Alias; +def dxc_I : DXCJoinedOrSeparateConflict<"I">, + HelpText<"Add directory to include search path">, beanz wrote: > This option

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6851 Group, Flags<[DXCOption, NoXarchOption]>, Alias; +def dxc_I : DXCJoinedOrSeparateConflict<"I">, + HelpText<"Add directory to include search path">, This option has the same

[PATCH] D128462: [HLSL] add -I option for dxc mode.

pow2clk added a comment. I'm confused by the ways this option is allowed to be specified Comment at: clang/include/clang/Driver/Options.td:6824 +class DXCJoinedOrSeparateConflict : Option<["--", "/", "-"], name, + KIND_JOINED_OR_SEPARATE>, Group, Flags<[DXCOption,

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae created this revision. python3kgae added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter, beanz, pow2clk. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits,