[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabeeae570eff: [X86] Support `_Float16` on SSE2 and up (authored by pengfei). Changed prior to commit:

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:357 +// Turn on _float16 for x86 (feature sse2) +HasFloat16 = SSELevel >= SSE2; MaskRay wrote: > MaskRay wrote: > > `_Float16` > > > > `for x86` convey no extra information

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/Targets/X86.cpp:357 +// Turn on _float16 for x86 (feature sse2) +HasFloat16 = SSELevel >= SSE2; MaskRay wrote: >

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei updated this revision to Diff 441272. pengfei added a comment. Address review comments. Thanks @MaskRay ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571 Files:

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:357 +// Turn on _float16 for x86 (feature sse2) +HasFloat16 = SSELevel >= SSE2; `_Float16` `for x86` convey no extra information since this file is for x86. Repository: rG

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Herald added a subscriber: StephenFan. Comment at: clang/test/CodeGen/X86/Float16-arithmetic.c:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown \ +//

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei updated this revision to Diff 441236. pengfei added a comment. Exclude the ABI change on Darwin platform. Will enable it by a followup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571 Files:

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei added a comment. In D128571#3619438 , @pengfei wrote: > In D128571#3619265 , @alexfh wrote: > >> @pengfei could you fix the Darwin tests as well? And a general comment >> regarding the ongoing `_Float16`

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei updated this revision to Diff 441222. pengfei added a comment. Disable `extendhfsf2/truncsfhf2` tests on Darwin to avoid the fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571 Files:

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei added a comment. In D128571#3619265 , @alexfh wrote: > @pengfei could you fix the Darwin tests as well? And a general comment > regarding the ongoing `_Float16` effort: I think that this change should have > been a part of

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei added a comment. Thanks @benlangmuir for the revert. The problem seems Darwin supports the `_Float16` type already but with a different ABI. I have no idea how to solve the problem ATM. Post a question on discourse:

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

alexfh added a comment. @pengfei could you fix the Darwin tests as well? And a general comment regarding the ongoing `_Float16` effort: I think that this change should have been a part of https://reviews.llvm.org/D107082 to make it possible to build a consistently working toolchain. Thus, if

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

benlangmuir added a comment. Reverted in eab2a06f0fde due to the Darwin test failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

benlangmuir added a comment. This broke some compiler-rt tests on Darwin: https://green.lab.llvm.org/green/job/clang-stage1-RA/29920/ Test Result (3 failures / +3) Builtins-x86_64-darwin.Builtins-x86_64-darwin.extendhfsf2_test.c

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei added a subscriber: vitalybuka. pengfei added a comment. Thanks @vitalybuka ! I believe the fail was caused by missing `COMPILER_RT_HAS_FLOAT16` in these tests. Relanded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

This revision was automatically updated to reflect the committed changes. Closed by commit rG527ef8ca981e: Reland [X86] Support `_Float16` on SSE2 and up (authored by pengfei). Herald added subscribers: Sanitizers, Enna1, mgorny. Herald added a project: Sanitizers. Changed prior to commit:

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5d781d6273c: [X86] Support `_Float16` on SSE2 and up (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

zahiraam accepted this revision. zahiraam added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571 ___ cfe-commits mailing list

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

rjmccall accepted this revision. rjmccall added a comment. Thank you, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571 ___ cfe-commits mailing list

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei updated this revision to Diff 440016. pengfei marked 3 inline comments as done. pengfei added a comment. Address review comments. Thanks @rjmccall ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

rjmccall added inline comments. Comment at: clang/docs/LanguageExtensions.rst:746 * SPIR -* X86 (Only available under feature AVX512-FP16) +* X86 (Enabled with feature SSE2 and up) Could you take the wording I suggested from the other patch? You'll need to

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei created this revision. pengfei added reviewers: zahiraam, rjmccall, bkramer, alexfh. Herald added a subscriber: jsji. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is split from D113107