Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

2015-10-02 Thread Samuel Antao via cfe-commits
sfantao closed this revision. sfantao added a comment. Committed in r249148! Thanks, Samuel http://reviews.llvm.org/D12871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

2015-10-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 36317. sfantao added a comment. Address Alexey's remarks from last review. http://reviews.llvm.org/D12871 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp lib/CodeGen/CodeGenFunction.h

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

2015-10-01 Thread Samuel Antao via cfe-commits
sfantao added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054 @@ +3043,13 @@ +Sizes.push_back(Size); +MapTypes.push_back(MapType); + } + + // Keep track on whether the host function has to be executed. + auto OffloadErrorQType = +

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

2015-09-23 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054 @@ +3043,13 @@ +Sizes.push_back(Size); +MapTypes.push_back(MapType); + } + + // Keep track on whether the host function has to be executed. + auto OffloadErrorQType = +

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

2015-09-18 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 35121. sfantao added a comment. Update if clause emission for target directive following Alexey's remark. http://reviews.llvm.org/D12871 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

2015-09-18 Thread Samuel Antao via cfe-commits
sfantao added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054 @@ +3043,13 @@ + + if (auto *VAT = dyn_cast(ElementType.getTypePtr())) { +auto VATInfo = CGF.getVLASize(VAT); +Size = llvm::ConstantInt::get( +CGM.SizeTy, +

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

2015-09-17 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054 @@ +3043,13 @@ + + if (auto *VAT = dyn_cast(ElementType.getTypePtr())) { +auto VATInfo = CGF.getVLASize(VAT); +Size = llvm::ConstantInt::get( +CGM.SizeTy, +

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

2015-09-16 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054 @@ +3043,13 @@ + + if (auto *VAT = dyn_cast(ElementType.getTypePtr())) { +auto VATInfo = CGF.getVLASize(VAT); +Size = llvm::ConstantInt::get( +CGM.SizeTy, +

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

2015-09-16 Thread Samuel Antao via cfe-commits
sfantao added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054 @@ +3043,13 @@ + + if (auto *VAT = dyn_cast(ElementType.getTypePtr())) { +auto VATInfo = CGF.getVLASize(VAT); +Size = llvm::ConstantInt::get( +CGM.SizeTy, +

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

2015-09-16 Thread Samuel Antao via cfe-commits
sfantao added inline comments. Comment at: lib/CodeGen/CGStmtOpenMP.cpp:80-81 @@ -67,1 +79,4 @@ II = ().Idents.get("vla"); + if (UseOnlyReferences) +ArgType = getContext().getLValueReferenceType( +ArgType, /*SpelledAsLValue=*/false);

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

2015-09-16 Thread Samuel Antao via cfe-commits
sfantao added inline comments. Comment at: lib/CodeGen/CGStmtOpenMP.cpp:121-123 @@ -103,4 +120,5 @@ +ArgLVal.getAddress(), ArgLVal.getType()->castAs()); auto *ExprArg = EmitLoadOfLValue(ArgLVal, SourceLocation()).getScalarVal(); auto VAT =

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

2015-09-16 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 34936. sfantao added a comment. Fix imprecision in previous diff. http://reviews.llvm.org/D12871 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp lib/CodeGen/CodeGenFunction.h

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

2015-09-15 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 34869. sfantao added a comment. Update code to use implicit parameters for the captured variables using `GenerateOpenMPCapturedStmtFunction`, similarly to what is done to other directives. `UseOnlyReferences` boolean was added to