NoQ added a subscriber: usama54321.
NoQ added a comment.
Thanks, very nice!
@usama54321 you recently fixed a similar problem in a clang-tidy check, do you
know if it also requires a similar clause for polymorphic expressions inside
`typeid`?
Repository:
rG LLVM Github Monorepo
CHANGES SINC
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcde1df4ca4f2: Correct -Winfinite-recursion warning on
potentially-unevaluated operand (authored by appmonster007, committed by
aaron.ballman).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST AC
appmonster007 updated this revision to Diff 441075.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128747/new/
https://reviews.llvm.org/D128747
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Analysis/CFG.cpp
clang/test/SemaCXX/warn-infinite-recur
appmonster007 added a comment.
Name : Prathit Aswar
github username : appmonster007
email : snaswar0...@gmail.com
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128747/new/
https://reviews.llvm.
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Thank you for the fix, the changes LGTM! From our off-review discussion, I
understand you need me to commit this on your behalf. What name and email
address would you like me to
appmonster007 updated this revision to Diff 441014.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128747/new/
https://reviews.llvm.org/D128747
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Analysis/CFG.cpp
clang/test/SemaCXX/warn-infinite-recur
appmonster007 updated this revision to Diff 441005.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128747/new/
https://reviews.llvm.org/D128747
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Analysis/CFG.cpp
clang/test/SemaCXX/warn-infinite-recur
appmonster007 updated this revision to Diff 440999.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128747/new/
https://reviews.llvm.org/D128747
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Analysis/CFG.cpp
clang/test/SemaCXX/warn-infinite-recur
appmonster007 updated this revision to Diff 440997.
appmonster007 marked an inline comment as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128747/new/
https://reviews.llvm.org/D128747
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Analysis/
appmonster007 updated this revision to Diff 440992.
appmonster007 added a comment.
inserted bullet point for `-Winfinite-recursion` diagnostics fix, where
diagnostic will not warn for unevaluated operands of ``typeid`` expression,
under "Improvements to Clang’s diagnostics" in clang/docs/Release
aaron.ballman added a comment.
Thank you for this fix, it's coming along well! Can you also add a release note
to `clang/docs/ReleaseNotes.rst` mentioning the fix?
Comment at: clang/lib/Analysis/CFG.cpp:4062
+ // operand. [...]
+ // We add only potentially evaluated statem
appmonster007 updated this revision to Diff 440859.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128747/new/
https://reviews.llvm.org/D128747
Files:
clang/lib/Analysis/CFG.cpp
clang/test/SemaCXX/typeinfo
clang/test/SemaCXX/warn-infinite-recur
appmonster007 updated this revision to Diff 440856.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128747/new/
https://reviews.llvm.org/D128747
Files:
clang/lib/Analysis/CFG.cpp
clang/test/SemaCXX/warn-infinite-recursion.cpp
Index: clang/test/S
appmonster007 added inline comments.
Comment at: clang/test/SemaCXX/warn-infinite-recursion.cpp:3
+#include "typeinfo"
+
`#include ` resulted in 'typeinfo' file not found with
include; use "quotes" instead
Repository:
rG LLVM Github Monorepo
CHANGES SINC
appmonster007 updated this revision to Diff 440845.
appmonster007 added a comment.
#include "typeinfo"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128747/new/
https://reviews.llvm.org/D128747
Files:
clang/lib/Analysis/CFG.cpp
clang/test/Sema
appmonster007 updated this revision to Diff 440835.
appmonster007 added a comment.
included typeinfo file, in clang/test/SemaCXX directory
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128747/new/
https://reviews.llvm.org/D128747
Files:
clang/li
appmonster007 updated this revision to Diff 440819.
appmonster007 added a comment.
fixed warning comments for test cases
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128747/new/
https://reviews.llvm.org/D128747
Files:
clang/lib/Analysis/CFG.cpp
shafik added a comment.
Thank for looking at this bug, just a small comment on the test.
Comment at: clang/test/SemaCXX/warn-infinite-recursion.cpp:178
+struct Q {
+ virtual ~Q(){};
+};
Looks like your missing `// expected-warning{{call itself}}`
Repository
appmonster007 created this revision.
appmonster007 added a reviewer: aaron.ballman.
appmonster007 added a project: clang.
Herald added a project: All.
appmonster007 requested review of this revision.
Herald added a subscriber: cfe-commits.
Fixing issue "incorrect -Winfinite-recursion warning on po
19 matches
Mail list logo
