[PATCH] D128754: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace

2022-07-08 Thread Cole Kissane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG96063bfa9088: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlibā€¦ (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128754: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace

2022-07-07 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. You may push this patch and its prerequisite while other patches are still to be reviewed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754

[PATCH] D128754: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace

2022-07-07 Thread Cole Kissane via Phabricator via cfe-commits
ckissane marked 4 inline comments as done. ckissane added a comment. mark handled comments as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 ___

[PATCH] D128754: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace

2022-07-07 Thread Cole Kissane via Phabricator via cfe-commits
ckissane updated this revision to Diff 443009. ckissane edited the summary of this revision. ckissane added a comment. - remove crc32 from zlib compression namespace - Merge branch 'ckissane.refactor-compression.part-0' into ckissane.refactor-compression.part-1 - Merge branch

[PATCH] D128754: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace

2022-07-01 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. Thanks! Comment at: llvm/lib/Support/Compression.cpp:25 using namespace llvm; using namespace llvm::compression; if a previous patch introduces a blank line between two `using`. please drop it from