leonardchan accepted this revision.
leonardchan added a comment.
This revision is now accepted and ready to land.
LGTM. Should probably add `[llvm]` to the subject also. Generally it's helpful
for immediately knowing which subrepo you're touching.
Repository:
rG LLVM Github Monorepo
CHANGES
ckissane updated this revision to Diff 441541.
ckissane added a comment.
- Merge branch 'ckissane.refactor-compression.part-0' into
ckissane.refactor-compression.part-1
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128754/new/
ckissane updated this revision to Diff 441537.
ckissane added a comment.
make part 1 after part 0 of refactor
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128754/new/
https://reviews.llvm.org/D128754
Files:
llvm/docs/ReleaseNotes.rst
MaskRay added inline comments.
Comment at: llvm/docs/ReleaseNotes.rst:183-191
+* Refactor compression namespaces across the project, making way for a possible
+ introduction of alternatives to zlib compression in the llvm toolchain.
+ Changes are as follows:
+ * Remove crc32
leonardchan added inline comments.
Comment at: llvm/docs/ReleaseNotes.rst:183-191
+* Refactor compression namespaces across the project, making way for a possible
+ introduction of alternatives to zlib compression in the llvm toolchain.
+ Changes are as follows:
+ * Remove
ckissane updated this revision to Diff 441113.
ckissane added a comment.
- Merge remote-tracking branch 'origin/main' into
ckissane.refactor-compression-namespace
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128754/new/
ckissane updated this revision to Diff 441107.
ckissane added a comment.
- feat: refactor llvm compression namespaces
- chore: update rel notes to note zlib::crc32 remove
- feat: add AlgorithmName to compression namespaces
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ckissane marked an inline comment as done.
ckissane added a comment.
Marked name of algorithm comments as done
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128754/new/
https://reviews.llvm.org/D128754
___
cfe-commits mailing list
ckissane updated this revision to Diff 441101.
ckissane added a comment.
add AlgorithmName to compression namespaces
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128754/new/
https://reviews.llvm.org/D128754
Files:
clang-tools-extra/clangd/index/Serialization.cpp
ckissane marked an inline comment as done.
ckissane added inline comments.
Comment at: clang-tools-extra/clangd/index/Serialization.cpp:242
+return error(
+"Compressed string table, but compression::serialize is unavailable");
leonardchan wrote:
>
ckissane marked an inline comment as done.
ckissane added inline comments.
Comment at: llvm/unittests/Support/CompressionTest.cpp:68
- 0x414FA339U,
- zlib::crc32(StringRef("The quick brown fox jumps over the lazy dog")));
-}
leonardchan wrote:
> Should
leonardchan added a comment.
> Feedback needed on:
> this namespace approach will result in tooling compression methods being set
> at compile time, however we may want to aim for a runtime configurable
> approach in the future, likely a new revision of the compressed data formats
> that llvm
ckissane updated this revision to Diff 440736.
ckissane added a comment.
up release notes
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128754/new/
https://reviews.llvm.org/D128754
Files:
clang-tools-extra/clangd/index/Serialization.cpp
ckissane created this revision.
ckissane added a reviewer: MaskRay.
ckissane added a project: LLVM.
Herald added subscribers: StephenFan, wenlei, usaxena95, kadircet, arphaman,
hiraditya, arichardson, mgorny, emaste.
Herald added a reviewer: alexander-shaposhnikov.
Herald added a reviewer:
14 matches
Mail list logo
