This revision was automatically updated to reflect the committed changes.
Closed by commit rG007934343c4c: [libTooling][NFC] Add a comment about comment
parsing to getAssociatedRange. (authored by jacobsa, committed by ymandel).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ymandel added a comment.
sure
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128774/new/
https://reviews.llvm.org/D128774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jacobsa marked an inline comment as done.
jacobsa added a comment.
@ymandel: thanks! Are you able to commit?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128774/new/
https://reviews.llvm.org/D128774
jacobsa updated this revision to Diff 441203.
jacobsa added a comment.
Address formatting comment from ymandel.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128774/new/
https://reviews.llvm.org/D128774
Files:
ymandel added inline comments.
Comment at: clang/include/clang/Tooling/Transformer/SourceCode.h:47
+/// range containing associated comments, you may need to invoke the tool with
+/// -fparse-all-comments.
CharSourceRange getAssociatedRange(const Decl , ASTContext );
ymandel accepted this revision.
ymandel added a comment.
This revision is now accepted and ready to land.
Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128774/new/
https://reviews.llvm.org/D128774
jacobsa created this revision.
jacobsa added a reviewer: klimek.
Herald added a project: All.
jacobsa requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
It took me multiple hours of debugging plus asking an expert for help to
figure out why
