[PATCH] D128927: [libc++] Always build c++experimental.a

hans added a comment. >> In https://github.com/llvm/llvm-zorg/pull/28 you mentioned that "for a >> couple of years now, Clang and libc++ are entirely separate projects w.r.t. >> how they are shipped on Apple platforms, and it doesn't make sense to build >> libc++ at the same time as Clang

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne added a comment. In D128927#3665748 , @hans wrote: > In D128927#3662659 , @ldionne wrote: > >> The weird part here is that you're configuring libc++, but you are building >> neither the static nor the

[PATCH] D128927: [libc++] Always build c++experimental.a

hans added a comment. In D128927#3662659 , @ldionne wrote: > The weird part here is that you're configuring libc++, but you are building > neither the static nor the shared library. I don't understand why you do > that, and that may hide some other

[PATCH] D128927: [libc++] Always build c++experimental.a

This revision was automatically updated to reflect the committed changes. Closed by commit rG7300a651f5f3: [libc++] Re-apply Always build c++experimental.a (authored by ldionne). Changed prior to commit: https://reviews.llvm.org/D128927?vs=443344=445822#toc Repository: rG LLVM Github

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne added a comment. The weird part here is that you're configuring libc++, but you are building neither the static nor the shared library. I don't understand why you do that, and that may hide some other more fundamental issue in your setup. Anyways, I think the issue should be resolved

[PATCH] D128927: [libc++] Always build c++experimental.a

hans added a subscriber: thakis. hans added a comment. After discussing with @thakis a bit, I've reverted this in 09cebfb978def7fa2a4460bca89690f8d3608216 to bring builds back to a green state while we figure out what's

[PATCH] D128927: [libc++] Always build c++experimental.a

hans added a comment. After some more digging, it seems we're hitting the same issue as we did back in https://reviews.llvm.org/D82702#2153130 and now the work-around of passing `-DLIBCXX_ENABLE_EXPERIMENTAL_LIBRARY=OFF` stopped working. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128927: [libc++] Always build c++experimental.a

hans added a comment. In D128927#3648652 , @ldionne wrote: > In D128927#3648616 , @fhahn wrote: > >> It looks like this is causing macOS builds to fail on GreenDragon. Please >> take a look and refer the commit

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne added a comment. In D128927#3648616 , @fhahn wrote: > It looks like this is causing macOS builds to fail on GreenDragon. Please > take a look and refer the commit if it takes longer to resolve, as the bot > has been red for a while now. Thanks

[PATCH] D128927: [libc++] Always build c++experimental.a

fhahn added a comment. It looks like this is causing macOS builds to fail on GreenDragon. Please take a look and refer the commit if it takes longer to resolve, as the bot has been red for a while now. [3495/5980]

[PATCH] D128927: [libc++] Always build c++experimental.a

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb939931a1ad: [libc++] Always build c++experimental.a (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne updated this revision to Diff 443342. ldionne added a comment. Rebase onto main and remove references to -funstable since the design is still changing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128927/new/

[PATCH] D128927: [libc++] Always build c++experimental.a

mstorsjo added a comment. In D128927#3638973 , @ldionne wrote: > Thanks @mstorsjo! Regarding `_LIBCPP_EXPERIMENTAL_FUNC_VIS`, yes I think it > would make sense to use a different visibility macro for symbols that we know > are provided only as part of

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne updated this revision to Diff 443252. ldionne marked an inline comment as done. ldionne added a comment. Windows fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128927/new/ https://reviews.llvm.org/D128927 Files:

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne marked an inline comment as done. ldionne added a comment. Thanks @mstorsjo! Regarding `_LIBCPP_EXPERIMENTAL_FUNC_VIS`, yes I think it would make sense to use a different visibility macro for symbols that we know are provided only as part of a static library. I would not call it

[PATCH] D128927: [libc++] Always build c++experimental.a

mstorsjo added a comment. It looks like the tests would work in CI in the clang-cl configurations with this modification: diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot index 65155ba173ed..407e93ef1575 100755 --- a/libcxx/utils/ci/run-buildbot +++

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne updated this revision to Diff 442667. ldionne added a comment. Rebase onto main and temporarily disable experimental tests on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128927/new/ https://reviews.llvm.org/D128927 Files:

[PATCH] D128927: [libc++] Always build c++experimental.a

Mordante accepted this revision. Mordante added a comment. I had a look at the changes and still LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128927/new/ https://reviews.llvm.org/D128927 ___

[PATCH] D128927: [libc++] Always build c++experimental.a

mstorsjo added a comment. In D128927#3622793 , @ldionne wrote: > @mstorsjo I might need some assistance figuring out what to do with the > Windows parts of this change. I can try to have a look in a couple days or so - I'm vacationing and have been

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne added inline comments. Comment at: libcxx/docs/ReleaseNotes.rst:226 + experimental features provided by it. Note that vendors are encouraged to ship the + experimental library now that the compiler provides an ergonomic way to use it. Mordante wrote:

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne updated this revision to Diff 442378. ldionne marked 2 inline comments as done. ldionne added a comment. Address review comments and try to fix some CI issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128927/new/

[PATCH] D128927: [libc++] Always build c++experimental.a

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. Thanks for working on this! LGTM with some suggestions. Comment at: libcxx/docs/ReleaseNotes.rst:226 + experimental features provided by it. Note that vendors are

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne added a subscriber: mstorsjo. ldionne added a comment. @mstorsjo I might need some assistance figuring out what to do with the Windows parts of this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128927/new/

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne created this revision. ldionne added a reviewer: Mordante. Herald added subscribers: Enna1, abrachet, arichardson, mgorny. Herald added a project: All. ldionne requested review of this revision. Herald added projects: clang, Sanitizers, libc++. Herald added subscribers: libcxx-commits,