leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land.
LGTM. Should also probably add `[NFC]` to the start of the subject ================ Comment at: lld/ELF/InputSection.cpp:77 + if (!compression::zlib::isAvailable()) + error(toString(file) + ": contains a compressed section, " + "but " + + compression::zlib::AlgorithmName + " is not available"); ---------------- `": contains a compressed section, " + "but "` -> `": contains a compressed section, but "` ================ Comment at: llvm/lib/ProfileData/InstrProf.cpp:154 + OS << ("profile uses " + compression::profile::AlgorithmName + + " compression but the profile reader was built " + "without " + + compression::profile::AlgorithmName + " support"); ---------------- `" compression but the profile reader was built " + "without "` -> `" compression but the profile reader was built without "` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128953/new/ https://reviews.llvm.org/D128953 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits