[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1fbc0519c52: [clangd] Support "usedAsMutableReference" in member initializations (authored by ckandeler, committed by nridge). Repository: rG LL

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler added a comment. In D128977#3638198 , @nridge wrote: > Yes, I plan to. I'm just building it locally to verify the tests are passing. > (And sometimes, for reasons I don't understand, LLVM's build system triggers > a full rebuild even though I'

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

nridge added a comment. Yes, I plan to. I'm just building it locally to verify the tests are passing. (And sometimes, for reasons I don't understand, LLVM's build system triggers a full rebuild even though I've only applied a patch that touches a couple of files...) Repository: rG LLVM Gith

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler added a comment. Can you please merge it as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128977/new/ https://reviews.llvm.org/D128977 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128977/new/ https://reviews.llvm.org/D128977

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler added a comment. Note that the build failure seems unrelated, as it's due to a failing clang-tidy test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128977/new/ https://reviews.llvm.org/D128977 _

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:541 + return Base::TraverseConstructorInitializer(Init); +if (const auto Member = Init->getMember()) { + const auto MemberType = Member->getType(); nridge

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler updated this revision to Diff 442257. ckandeler marked 4 inline comments as done. ckandeler added a comment. Implemented reviewer suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128977/new/ https://reviews.llvm.org/D128977 Fil

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

nridge requested changes to this revision. nridge added a comment. This revision now requires changes to proceed. Thanks, this seems like a useful extension of the `usedAsMutableReference` modifier Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:541 + return

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. That is, mark constructor pa