[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb069801ffb6d: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D129277#3637317 , @mstorsjo wrote: > In D129277#3636795 , @aaron.ballman > wrote: > >> In

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

mstorsjo updated this revision to Diff 443075. mstorsjo added a comment. Add `/*Diags=*/nullptr` for clarity, as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129277/new/ https://reviews.llvm.org/D129277 Files:

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

mstorsjo added a comment. In D129277#3636795 , @aaron.ballman wrote: > In D129277#3636596 , @mstorsjo > wrote: > >> In D129277#3636567 , >> @aaron.ballman wrote: >>

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

shafik added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:5174 std::string ) override { - return checkPreprocessorOptions(ExistingPPOpts, PPOpts, nullptr, FileMgr, + return checkPreprocessorOptions(PPOpts,

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

aaron.ballman added a comment. In D129277#3636596 , @mstorsjo wrote: > In D129277#3636567 , @aaron.ballman > wrote: > >> Thanks for catching this! Is it really an NFC change though (it seems like >> it would

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

mstorsjo added a comment. In D129277#3636567 , @aaron.ballman wrote: > Thanks for catching this! Is it really an NFC change though (it seems like it > would change some of the diagnostic behavior and the list of suggested > predefines)? Can you add

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

aaron.ballman added a comment. Thanks for catching this! Is it really an NFC change though (it seems like it would change some of the diagnostic behavior and the list of suggested predefines)? Can you add test coverage for the change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

mstorsjo created this revision. mstorsjo added reviewers: aaron.ballman, rnk, shafik. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. The two first parameters of checkPreprocessorOptions are "PPOpts, ExistingPPOpts". All other callers of