[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath added a comment. I do not have commit access. Could you please commit on my behalf? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129311/new/ https://reviews.llvm.org/D129311

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath updated this revision to Diff 448099. sridhar_gopinath marked an inline comment as done. sridhar_gopinath added a comment. Addressed nitpick Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129311/new/

[PATCH] D129311: [clang-format] Update return code

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. Thanks for the explanations! LGTM. Comment at: clang/tools/clang-format/git-clang-format:539-540 # filter. - subprocess.check_call(['git', 'diff', '--diff-filter=M',

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath marked 3 inline comments as done. sridhar_gopinath added inline comments. Comment at: clang/tools/clang-format/git-clang-format:201 if opts.diff: -print_diff(old_tree, new_tree) - elif opts.diffstat: -print_diffstat(old_tree, new_tree) - else: -

[PATCH] D129311: [clang-format] Update return code

owenpan added inline comments. Comment at: clang/tools/clang-format/git-clang-format:201 if opts.diff: -print_diff(old_tree, new_tree) - elif opts.diffstat: -print_diffstat(old_tree, new_tree) - else: -changed_files = apply_changes(old_tree, new_tree,

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath marked 2 inline comments as done. sridhar_gopinath added inline comments. Comment at: clang/tools/clang-format/git-clang-format:579 with temporary_index_file(old_tree): - subprocess.check_call(['git', 'checkout', '--patch', new_tree]) +

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath updated this revision to Diff 446581. sridhar_gopinath added a comment. Removed '--' in the git-diff commands as it only applies to files and not commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129311/new/

[PATCH] D129311: [clang-format] Update return code

owenpan added inline comments. Comment at: clang/tools/clang-format/git-clang-format:579 with temporary_index_file(old_tree): - subprocess.check_call(['git', 'checkout', '--patch', new_tree]) + subprocess.run(['git', 'checkout', '--patch', new_tree], check=True)

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath marked 4 inline comments as done. sridhar_gopinath added inline comments. Comment at: clang/tools/clang-format/git-clang-format:539-540 # filter. - subprocess.check_call(['git', 'diff', '--diff-filter=M', old_tree, new_tree, - '--'])

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath updated this revision to Diff 445954. sridhar_gopinath marked 4 inline comments as done. sridhar_gopinath added a comment. Changes to the args order and changing check_call -> run Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129311: [clang-format] Update return code

owenpan added a comment. Please mark as done if you have addressed an inline comment. Comment at: clang/tools/clang-format/git-clang-format:539-540 # filter. - subprocess.check_call(['git', 'diff', '--diff-filter=M', old_tree, new_tree, - '--']) +

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath updated this revision to Diff 445652. sridhar_gopinath added a comment. Updated subprocess.call -> subprocess.run Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129311/new/ https://reviews.llvm.org/D129311 Files:

[PATCH] D129311: [clang-format] Update return code

owenpan added inline comments. Comment at: clang/tools/clang-format/git-clang-format:539 # filter. - subprocess.check_call(['git', 'diff', '--diff-filter=M', old_tree, new_tree, - '--']) + return subprocess.call(['git', 'diff', '--diff-filter=M', +

Re: [PATCH] D129311: [clang-format] Update return code

Could someone please review this change? Thanks! — Sridhar > On Jul 11, 2022, at 12:55 PM, Sridhar Gopinath via Phabricator > wrote: > > sridhar_gopinath updated this revision to Diff 443726. > sridhar_gopinath added a comment. > > Replaced subprocess.check_call with subprocess.call since

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath updated this revision to Diff 443726. sridhar_gopinath added a comment. Replaced subprocess.check_call with subprocess.call since the former crashes when the return code is not zero. + formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129311: [clang-format] Update return code

owenpan added inline comments. Comment at: clang/tools/clang-format/git-clang-format:202 +return print_diff(old_tree, new_tree) elif opts.diffstat: +return print_diffstat(old_tree, new_tree) Comment at:

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath created this revision. sridhar_gopinath added reviewers: curdeius, owenpan. Herald added a project: All. sridhar_gopinath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In diff and diffstat modes, the return code is != 0