royjacobson added a comment.
Thanks for the suggestions and for the quick review! @aaron.ballman
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129583/new/
https://reviews.llvm.org/D129583
___
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG202b327f5d29: [DOC] Add DR1734 and DR1496 Clangs
cxx_dr_status as not implemented (authored by royjacobson).
Repository:
rG LLVM Github Monorepo
royjacobson updated this revision to Diff 22.
royjacobson added a comment.
Update comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129583/new/
https://reviews.llvm.org/D129583
Files:
clang/test/CXX/drs/dr14xx.cpp
aaron.ballman added a comment.
Thanks for the updated tests! Some minor commenting suggestions (that will need
to be re-flowed to 80 col limit), but otherwise LGTM!
Comment at: clang/test/CXX/drs/dr14xx.cpp:510
+};
+// FIXME: A should not be trivial.
royjacobson created this revision.
Herald added a project: All.
royjacobson requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Those two DRs about the (copy) triviality of types with deleted special member
functions are not implemented in
