[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

h-vetinari added a comment. In D129635#4451189 , @saiislam wrote:> > Are there any features in this table which have been already implemented but > have not been tagged? > https://clang.llvm.org/docs/OpenMPSupport.html#openmp-5-1-implementation-details

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

saiislam added a comment. @jdoerfert @RaviNarayanaswamy @ABataev Are there any features in this table which have been already implemented but have not been tagged? https://clang.llvm.org/docs/OpenMPSupport.html#openmp-5-1-implementation-details Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

animeshk-amd added a comment. In D129635#4442580 , @h-vetinari wrote: > In D129635#4440613 , @animeshk-amd > wrote: > >> In the multi-company community meeting, the agreement was to move to the 5.1 >> version

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

h-vetinari added a comment. In D129635#4440613 , @animeshk-amd wrote: > In the multi-company community meeting, the agreement was to move to the 5.1 > version assuming that these features are supported. We shouldn't need to assume - either the

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

animeshk-amd added a comment. In D129635#4438970 , @h-vetinari wrote: > Does https://clang.llvm.org/docs/OpenMPSupport.html need an update? It still > says "Clang fully supports OpenMP 4.5" (with many 5.0/5.1 features marked as > "worked on" /

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

h-vetinari added a comment. Does https://clang.llvm.org/docs/OpenMPSupport.html need an update? It still says "Clang fully supports OpenMP 4.5" (with many 5.0/5.1 features marked as "worked on" / "unclaimed"), which would make it unusual to put the default on a version that's (according to

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c6f2f629cc0: [OpenMP] Update the default version of OpenMP to 5.1 (authored by animeshk-amd). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

saiislam accepted this revision. saiislam added a comment. Thank you @animeshk-amd! LGTM! As discussed in the multi-company OpenMP LLVM meeting, this is the right time to upgrade the default OpenMP spec version to 5.1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

animeshk-amd updated this revision to Diff 531189. animeshk-amd added a comment. Herald added subscribers: jplehr, sunshaoce, pcwang-thead. Rebase and fixing the merge conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129635/new/

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

saiislam accepted this revision. saiislam added a comment. Thanks, LGTM! In the multi-company OpenMP meeting, it was decided to defer this update. So, please don't land this patch yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129635/new/

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

animeshk-amd updated this revision to Diff 447998. animeshk-amd edited the summary of this revision. animeshk-amd added a comment. Herald added subscribers: openmp-commits, steakhal, arphaman. Herald added a project: OpenMP. [OpenMP] Update more LIT tests to support OpenMP version upgrade Some

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

animeshk-amd updated this revision to Diff 446359. animeshk-amd added a comment. Herald added a subscriber: zzheng. [OpenMP] Update remaining tests for OpenMP version update to 5.1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129635/new/

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129635/new/ https://reviews.llvm.org/D129635

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

animeshk-amd created this revision. animeshk-amd added reviewers: saiislam, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. animeshk-amd requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.