[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d0cc510516d: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

egorzhdan added a comment. Thanks @brad @3405691582 @MaskRay for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129654/new/ https://reviews.llvm.org/D129654 ___ cfe-commits mailing list

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

egorzhdan updated this revision to Diff 446223. egorzhdan added a comment. - Add a test for OpenBSD - Modify existing test file instead of adding a new file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129654/new/ https://reviews.llvm.org/D129654

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

brad added a comment. Also -stdlib=libc++ is the default on OpenBSD and FreeBSD so you can probably leave that out and I think you can remove --gcc-toolchain="". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129654/new/

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

brad added a comment. In D129654#3650590 , @3405691582 wrote: > As mentioned, this replicates https://reviews.llvm.org/D126289 for OpenBSD > which fixes #28283. That particular issue caused a build problem in Swift's > use of VFS in which I verified

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

3405691582 added a comment. In D129654#3650534 , @brad wrote: > In D129654#3650412 , @3405691582 > wrote: > >> Tested change on OpenBSD resolves downstream issues. > > What issues? As mentioned, this replicates

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

brad added a comment. In D129654#3650412 , @3405691582 wrote: > Tested change on OpenBSD resolves downstream issues. What issues? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129654/new/

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

3405691582 accepted this revision. 3405691582 added a comment. This revision is now accepted and ready to land. LGTM. Tested change on OpenBSD, was not able to check FreeBSD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129654/new/

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

brad added a comment. There is already the initial --sysroot test in test/Driver/openbsd.c. It would be preferable to modify what is there. For FreeBSD a test should be added to test/Driver/freebsd.c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

MaskRay added a comment. Linux tests organization isn't great. --sysroot tests both include and library search paths, so ideally we use one RUN line to test both. The name of linux-header-search.cpp focus on just include search path. For FreeBSD/OpenBSD, if you want to start in a clean state,

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

egorzhdan created this revision. Herald added subscribers: krytarowski, arichardson, emaste. Herald added a project: All. egorzhdan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This is the same change as