[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

MaskRay added inline comments. Comment at: clang/test/CodeGen/attr-function-return.c:9 // RUN: --check-prefixes=CHECK,CHECK-EXTERN +// RUN: %clang_cc1 -std=gnu2x -triple x86_64-linux-gnu %s -emit-llvm -o - \ +// RUN: -mfunction-return=thunk-extern -fprofile-arcs \

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/attr-function-return.c:9 // RUN: --check-prefixes=CHECK,CHECK-EXTERN +// RUN: %clang_cc1 -std=gnu2x -triple x86_64-linux-gnu %s -emit-llvm -o - \ +// RUN: -mfunction-return=thunk-extern -fprofile-arcs \

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG140bfdca60ae: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/CodeGen/attr-function-return.c:9 // RUN: --check-prefixes=CHECK,CHECK-EXTERN +// RUN: %clang_cc1 -std=gnu2x -triple x86_64-linux-gnu %s -emit-llvm -o - \ +// RUN:

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers updated this revision to Diff 444743. nickdesaulniers added a comment. - resort langref, oops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129709/new/ https://reviews.llvm.org/D129709 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers added a comment. Thanks for the review! Comment at: clang/test/CodeGen/attr-function-return.c:9 // RUN: --check-prefixes=CHECK,CHECK-EXTERN +// RUN: %clang_cc1 -std=gnu2x -triple x86_64-linux-gnu %s -emit-llvm -o - \ +// RUN: -mfunction-return=thunk-extern

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers updated this revision to Diff 444742. nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. - rename md idententifier, sort langref Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129709/new/

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

MaskRay added inline comments. Comment at: llvm/lib/IR/Function.cpp:357 } + if (M->getModuleFlag("fn_return_thunk_extern")) +B.addAttribute(Attribute::FnRetThunkExtern); How about "function_return_thunk_extern"? fn doesn't abbreviate much. Having the

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > https://github.com/llvm/llvm-project/issues/56514 > > Fixes #56514 Just use `Fixes https://github.com/llvm/llvm-project/issues/56514` or `Fixes #56514`. GitHub can close the issue

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers updated this revision to Diff 444725. nickdesaulniers added a comment. - rebase on top of D129691 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129709/new/ https://reviews.llvm.org/D129709 Files:

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nathanchance added a comment. This cleans up the objtool warnings I initially reported and does not introduce any other regressions in my Linux kernel build and QEMU boot tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129709/new/

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/attr-function-return.c:107 +// CHECK-GCOV: @__llvm_gcov_init() unnamed_addr [[EXTERNGCOV]] +// CHECK-ASAN: @asan.module_ctor() [[EXTERNASAN:#[0-9]+]] +// CHECK-TSAN: @tsan.module_ctor() [[EXTERNTSAN:#[0-9]+]]

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers created this revision. nickdesaulniers added reviewers: MaskRay, void. Herald added subscribers: jsji, StephenFan, jdoerfert, pengfei, hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added