[PATCH] D129951: [clang] teaches Clang the special ADL rules for functions in std::ranges

cjdb added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9438 // FIXME: Pass in the explicit template arguments? ArgumentDependentLookup(Name, Loc, Args, Fns); rsmith wrote: > It would seem preferable to me to do the filtering in >

[PATCH] D129951: [clang] teaches Clang the special ADL rules for functions in std::ranges

rsmith added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9438 // FIXME: Pass in the explicit template arguments? ArgumentDependentLookup(Name, Loc, Args, Fns); It would seem preferable to me to do the filtering in

[PATCH] D129951: [clang] teaches Clang the special ADL rules for functions in std::ranges

cjdb added a comment. In D129951#3657923 , @cjdb wrote: > ~~Looking at the output from Clang 14 , I'm > observing that a binary with 178 function templates is 13% the size of the > one with 89 function objects. When

[PATCH] D129951: [clang] teaches Clang the special ADL rules for functions in std::ranges

cjdb added a comment. Looking at the output from Clang 14 , I'm observing that a binary with 178 function templates is 13% the size of the one with 89 function objects. When only one function object is used vs all 178 function templates, the functions still win

[PATCH] D129951: [clang] teaches Clang the special ADL rules for functions in std::ranges

cjdb updated this revision to Diff 445286. cjdb edited the summary of this revision. cjdb added a comment. updates an inaccuracy in the commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129951/new/ https://reviews.llvm.org/D129951

[PATCH] D129951: [clang] teaches Clang the special ADL rules for functions in std::ranges

cjdb updated this revision to Diff 445285. cjdb added a comment. moves test from Sema to SemaCXX I Noticed that SemaCXX is only a test directory, and that there's no corresponding SemaCXX in either include or lib. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129951: [clang] teaches Clang the special ADL rules for functions in std::ranges

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per per [range.iter.ops]/2 and [algorithms.requirements]/2, functions declared in the