[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

thakis added a comment. ps: Thank you to everyone who's been working on having fewer offload wrapper binaries! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130020/new/ https://reviews.llvm.org/D130020

[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

jhuber6 added a comment. In D130020#3752458 , @thakis wrote: > This caused: > > In file included from ../../clang/lib/Driver/ToolChains/Cuda.cpp:9: > ../../clang/lib/Driver/ToolChains/Cuda.h:193:29: warning: private field > 'OK' is not used

[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

thakis added a comment. This caused: In file included from ../../clang/lib/Driver/ToolChains/Cuda.cpp:9: ../../clang/lib/Driver/ToolChains/Cuda.h:193:29: warning: private field 'OK' is not used [-Wunused-private-field] const Action::OffloadKind OK; ^

[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

jhuber6 added a comment. In D130020#3746076 , @MaskRay wrote: > This is "remove" instead of "deprecate"? Yes, "remove" is probably more appropriate as this completely removes support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

MaskRay accepted this revision. MaskRay added a comment. This is "remove" instead of "deprecate"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130020/new/ https://reviews.llvm.org/D130020 ___

[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

ye-luo accepted this revision. ye-luo added a comment. The new driver remains failing offload to x86 in certain scenarios when linking static libraries. Once I link object files directly there is no issue. This not worse than old driver that only supports linking object files directly.

[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, as discussed over many weeks in our calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130020/new/ https://reviews.llvm.org/D130020

[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

ye-luo added a comment. I noticed that in one of my applications, offload to x86 is not fully working with static libraries but directly linking all object files resolves the issue. So the new driver doesn't cause regression compared to the old driver which doesn't work with static libraries