This revision was automatically updated to reflect the committed changes.
Closed by commit rG94ca2beccc59: [clang][analyzer] Added partial wide character
support to CStringChecker (authored by balazske).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
balazske added inline comments.
Comment at: clang/test/Analysis/wstring.c:385
+ wchar_t a[32];
+ // FIXME: This should work with 'w_str' instead of 'w_str1'
+ const wchar_t w_str1[] = L"Hello world";
martong wrote:
> balazske wrote:
> > The problem may be
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: rnkovacs.
Okay, thanks for the update. LGTM!
Comment at: clang/test/Analysis/wstring.c:385
+ wchar_t a[32];
+ // FIXME: This should work with
balazske added inline comments.
Comment at: clang/test/Analysis/wstring.c:385
+ wchar_t a[32];
+ // FIXME: This should work with 'w_str' instead of 'w_str1'
+ const wchar_t w_str1[] = L"Hello world";
The problem may be that the global constant is not
balazske added a comment.
I did not found the existing tests in other files, now all tests for the
"non-wide" functions are copied for the "wide" functions. I do not like fully
this solution but a single test file with macros for wide and non-wide case is
probably not better.
Repository:
balazske updated this revision to Diff 446385.
balazske added a comment.
Fix in overlap check, replaced test file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130091/new/
https://reviews.llvm.org/D130091
Files:
martong added a comment.
Nice improvement and the tests are meaningful!
> clang/test/Analysis/cstring.c
Hadn't we have already a test file for this checker? What about `string.c` and
`bstring.c`? You might have added redundant test cases in the new test file.
Comment at:
balazske created this revision.
Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411,
dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet,
baloghadamsoftware, xazax.hun.
Herald added a reviewer: Szelethus.
Herald added a reviewer: NoQ.
Herald added a
