Re: [PATCH] D13014: [X86] Add XSAVE intrinsics (Clang part)

2015-10-13 Thread Elena Demikhovsky via cfe-commits
delena added a comment. You should add the "xsave" features to all appropriate CPUs. It can be done in a separate patch. LGTM. Repository: rL LLVM http://reviews.llvm.org/D13014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13014: [X86] Add XSAVE intrinsics (Clang part)

2015-10-13 Thread Amjad Aboud via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250158: [X86] Add XSAVE intrinsic family (authored by aaboud). Changed prior to commit: http://reviews.llvm.org/D13014?vs=37108=37238#toc Repository: rL LLVM http://reviews.llvm.org/D13014 Files:

Re: [PATCH] D13014: [X86] Add XSAVE intrinsics (Clang part)

2015-10-12 Thread Elena Demikhovsky via cfe-commits
delena added a comment. Do you need to add some tests for clang? Repository: rL LLVM http://reviews.llvm.org/D13014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13014: [X86] Add XSAVE intrinsics (Clang part)

2015-10-12 Thread Amjad Aboud via cfe-commits
aaboud updated this revision to Diff 37108. aaboud added a comment. Added two LIT tests to check the xsave intrinsic instructions. Repository: rL LLVM http://reviews.llvm.org/D13014 Files: include/clang/Basic/BuiltinsX86.def lib/CodeGen/CGBuiltin.cpp lib/Headers/CMakeLists.txt

[PATCH] D13014: [X86] Add XSAVE intrinsics (Clang part)

2015-09-21 Thread Amjad Aboud via cfe-commits
aaboud created this revision. aaboud added reviewers: mkuper, delena, craig.topper. aaboud added a subscriber: cfe-commits. aaboud set the repository for this revision to rL LLVM. Add intrinsics for the XSAVE instructions: XSAVE, XSAVE64 XRSTOR, XRSTOR64 XSAVEOPT, XSAVEOPT64 XRSTORS, XRSTORS64