This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGea50901aa9e5: [clang-doc] Default to Standalone executor and
improve documentation (authored by phosek).
Repository:
rG LLVM Github Monorepo
phosek updated this revision to Diff 450055.
phosek marked an inline comment as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130226/new/
https://reviews.llvm.org/D130226
Files:
clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
abrachet accepted this revision.
abrachet added inline comments.
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:195
+ $ clang-doc --executor=all-TUs compile_commands.json
+ )";
+
Is it intentional that the rest of this help message also has two
phosek updated this revision to Diff 450039.
phosek marked 3 inline comments as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130226/new/
https://reviews.llvm.org/D130226
Files:
clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
paulkirth accepted this revision.
paulkirth added a comment.
This revision is now accepted and ready to land.
LGTM w/ the caveat that I think we should update the release notes, since we're
changing the default behavior of a command line tool. I've also left a few
small suggestions the wording.
phosek created this revision.
phosek added reviewers: abrachet, paulkirth.
Herald added subscribers: usaxena95, arphaman.
Herald added a project: All.
phosek requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
This should provide a
