[PATCH] D130303: Fix include order in CXType.cpp

aaron.ballman added a comment. I reverted this patch in 20fb4c3270b9d3596f213623d39c507711d1c165 and I've put up a new patch for review at https://reviews.llvm.org/D146039. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D130303: Fix include order in CXType.cpp

vedgy added inline comments. Comment at: clang/tools/libclang/CXType.cpp:374 +unsigned clang_isBitFieldDecl(CXCursor C) { + using namespace cxcursor; aaron.ballman wrote: > vedgy wrote: > > vedgy wrote: > > > I just noticed the `clang_Cursor_isBitField()`

[PATCH] D130303: Fix include order in CXType.cpp

aaron.ballman added inline comments. Comment at: clang/tools/libclang/CXType.cpp:374 +unsigned clang_isBitFieldDecl(CXCursor C) { + using namespace cxcursor; vedgy wrote: > vedgy wrote: > > I just noticed the `clang_Cursor_isBitField()` function implemented

[PATCH] D130303: Fix include order in CXType.cpp

vedgy added inline comments. Comment at: clang/tools/libclang/CXType.cpp:374 +unsigned clang_isBitFieldDecl(CXCursor C) { + using namespace cxcursor; vedgy wrote: > I just noticed the `clang_Cursor_isBitField()` function implemented [[ >

[PATCH] D130303: Fix include order in CXType.cpp

vedgy added inline comments. Comment at: clang/tools/libclang/CXType.cpp:374 +unsigned clang_isBitFieldDecl(CXCursor C) { + using namespace cxcursor; I just noticed the `clang_Cursor_isBitField()` function implemented [[

[PATCH] D130303: Fix include order in CXType.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d55a0b512a1: Fix include order in CXType.cpp (authored by collinbaker, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130303: Fix include order in CXType.cpp

collinbaker added a comment. Collin Baker collinba...@chromium.org This should also be in the author field of the commits Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303

[PATCH] D130303: Fix include order in CXType.cpp

aaron.ballman added a comment. In D130303#4183081 , @collinbaker wrote: > All done. Again, I don't have commit access so someone else will need to land > this. I can do that for you -- what name and email address would you like me to use for patch

[PATCH] D130303: Fix include order in CXType.cpp

collinbaker added a comment. All done. Again, I don't have commit access so someone else will need to land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303

[PATCH] D130303: Fix include order in CXType.cpp

collinbaker updated this revision to Diff 503954. collinbaker added a comment. Rebase w/ conflict in libclang.map Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 Files: clang/docs/ReleaseNotes.rst

[PATCH] D130303: Fix include order in CXType.cpp

collinbaker marked 5 inline comments as done. collinbaker added a comment. I am very bad at using differential Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303

[PATCH] D130303: Fix include order in CXType.cpp

collinbaker updated this revision to Diff 503953. collinbaker retitled this revision from "Handle template parameter-dependent bit field widths in libclang" to "Fix include order in CXType.cpp". collinbaker edited the summary of this revision. collinbaker added a comment. Re-add "Fixes" commit