Re: [PATCH] D130414: [pseudo] Reorganize CXX.h enums

Sorry Doug! 7b70c2e75cd6b21cf9c2ea2f2ce5f7b9c4202549 should fix, not sure why my local clang accepts it. On Wed, Jul 27, 2022 at 9:57 AM Douglas Yung via Phabricator < revi...@reviews.llvm.org> wrote: > dyung added a comment. > > Hi @sammccall, your change seems to be causing a build failure on

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

dyung added a comment. Hi @sammccall, your change seems to be causing a build failure on the PS4 linux bot, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/25678 FAILED: tools/clang/tools/extra/pseudo/gen/CMakeFiles/clang-pseudo-gen.dir/Main.cpp.o CCACHE_CPP2=yes

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rG6bdb15fe844c: [pseudo] Reorganize CXX.h enums (authored by sammccall). Herald added a subscriber:

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. I think this patch is in a good state. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/cxx/CXX.h:54 +namespace rules { +namespace dummy { +enum Rule {

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

sammccall updated this revision to Diff 447675. sammccall marked an inline comment as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130414/new/ https://reviews.llvm.org/D130414 Files:

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

sammccall marked 6 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/cxx/CXX.h:54 +namespace rules { +namespace dummy { +enum Rule { hokein wrote: > sammccall wrote: > > usaxena95 wrote: > > >

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

hokein added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/cxx/CXX.h:54 +namespace rules { +namespace dummy { +enum Rule { usaxena95 wrote: > sammccall wrote: > > hokein wrote: > > > why there is a dummy namespace here? > > for each

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

sammccall updated this revision to Diff 447286. sammccall added a comment. tweak formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130414/new/ https://reviews.llvm.org/D130414 Files: clang-tools-extra/pseudo/gen/Main.cpp

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

usaxena95 added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/cxx/CXX.h:54-62 +namespace dummy { +enum Rule { +//clang-format off +#define NONTERMINAL(NAME, ID) };} namespace NAME { enum Rule : RuleID { +#define RULE(LHS, RHS, ID) RHS = ID, #include

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/cxx/CXX.h:54 +namespace rules { +namespace dummy { +enum Rule { hokein wrote: > why there is a dummy namespace here? for each NT, we close the previous ns+enum and open

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

hokein added a comment. Thanks for exploring the idea, this looks like a good start to me. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/cxx/CXX.h:54 +namespace rules { +namespace dummy { +enum Rule { why there is a dummy namespace here?

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

sammccall created this revision. sammccall added reviewers: hokein, usaxena95. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. - Place rules under rule::lhs::rhs__rhs__rhs -