[PATCH] D130422: [clang-repl] Fix incorrect return code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9caee577ef0f: [clang-repl] Fix incorrect return code (authored by junaire). Changed prior to commit:

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire added inline comments. Comment at: clang/tools/clang-repl/ClangRepl.cpp:138 - return checkDiagErrors(Interp->getCompilerInstance()); + llvm::llvm_shutdown(); + v.g.vassilev wrote: > This seems not needed. We have already `llvm::llvm_shutdown_obj Y;`

[PATCH] D130422: [clang-repl] Fix incorrect return code

v.g.vassilev accepted this revision. v.g.vassilev added inline comments. Comment at: clang/tools/clang-repl/ClangRepl.cpp:138 - return checkDiagErrors(Interp->getCompilerInstance()); + llvm::llvm_shutdown(); + This seems not needed. We have already

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire added a comment. @v.g.vassilev if you can take another look at the wording of the FIXME, and make sure you're happy about it, that will be awesome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130422/new/ https://reviews.llvm.org/D130422

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire updated this revision to Diff 448846. junaire added a comment. Fix some typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130422/new/ https://reviews.llvm.org/D130422 Files: clang/test/Interpreter/fail.cpp

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire updated this revision to Diff 448844. junaire added a comment. Rebase and add a FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130422/new/ https://reviews.llvm.org/D130422 Files: clang/test/Interpreter/fail.cpp

[PATCH] D130422: [clang-repl] Fix incorrect return code

v.g.vassilev added a comment. In D130422#3689397 , @junaire wrote: > In D130422#3689392 , @v.g.vassilev > wrote: > >> Thanks for working on this. This is one of the problems where is hard to >> find the right

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire added a comment. In D130422#3689392 , @v.g.vassilev wrote: > Thanks for working on this. This is one of the problems where is hard to find > the right behavior. For example, if a repl running in interactive issues an > error and then

[PATCH] D130422: [clang-repl] Fix incorrect return code

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Thanks for working on this. This is one of the problems where is hard to find the right behavior. For example, if a repl running in interactive issues an error and then

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire updated this revision to Diff 447103. junaire added a comment. Use `not` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130422/new/ https://reviews.llvm.org/D130422 Files: clang/test/Interpreter/fail.cpp

[PATCH] D130422: [clang-repl] Fix incorrect return code

v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/fail.cpp:6 +// UNSUPPORTED: system-aix +// XFAIL: * +// CHECK-DRIVER: i = 10 Why this is marked as XFAIL? If it is only for the return code we can add the `not` command in front to make the

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without this patch, clang-repl incorrectly pass some tests when there's error