[PATCH] D130705: [clang][ASTImporter] Improve import of functions with auto return type.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4ff9eff767c: [clang][ASTImporter] Improve import of functions with auto return type. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130705: [clang][ASTImporter] Improve import of functions with auto return type.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thank you for the update! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130705/new/ https://reviews.llvm.org/D130705

[PATCH] D130705: [clang][ASTImporter] Improve import of functions with auto return type.

balazske updated this revision to Diff 450716. balazske added a comment. Removed one unreachable, added new tests, improvement of `TagDecl` check, re-arranged source code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130705/new/

[PATCH] D130705: [clang][ASTImporter] Improve import of functions with auto return type.

martong added a comment. Thank you, nice and assiduous work! The changes look good to me, but I think we should have some more tests where variable and function template specializations are used as return types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130705: [clang][ASTImporter] Improve import of functions with auto return type.

balazske updated this revision to Diff 449668. balazske added a comment. - Added a new test - Call the visitor only if the function has auto return type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130705/new/ https://reviews.llvm.org/D130705

[PATCH] D130705: [clang][ASTImporter] Improve import of functions with auto return type.

balazske added a comment. Yes, I plan to add improvements but the current code remains mostly. I found other type of error (in project //qtbase//) that are not directly related, too (infinite import loop of deduction guide without auto return value, one of the function arguments is involved),

[PATCH] D130705: [clang][ASTImporter] Improve import of functions with auto return type.

martong added a comment. In D130705#3685299 , @balazske wrote: > It is still not perfect, analysis of qtbase is not better than before and > some of the unreachable assertions were encountered. Does it mean you plan some updates on this patch?

[PATCH] D130705: [clang][ASTImporter] Improve import of functions with auto return type.

balazske added a comment. It is still not perfect, analysis of qtbase is not better than before and some of the unreachable assertions were encountered. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130705/new/ https://reviews.llvm.org/D130705

[PATCH] D130705: [clang][ASTImporter] Improve import of functions with auto return type.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a