[PATCH] D130791: [clang] Short-circuit trivial constexpr array constructors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11e52ecf74e9: [clang] Short-circuit trivial constructors when evaluating arrays (authored by tbaeder). Changed prior to commit:

[PATCH] D130791: [clang] Short-circuit trivial constexpr array constructors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I agree that test coverage for the performance issue is basically impossible with our testing system. I was thinking "well good, add a test with a huge initializer to make

[PATCH] D130791: [clang] Short-circuit trivial constexpr array constructors

tbaeder updated this revision to Diff 449182. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130791/new/ https://reviews.llvm.org/D130791 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant.cpp Index: clang/lib/AST/ExprConstant.cpp

[PATCH] D130791: [clang] Short-circuit trivial constexpr array constructors

tbaeder added a comment. In D130791#3692071 , @dblaikie wrote: > also: What about zero length arrays? (which are supported as an extension) - > this change would cause failures that wouldn't be emitted in the old code? There's a `if (FinalSize == 0)

[PATCH] D130791: [clang] Short-circuit trivial constexpr array constructors

dblaikie added a comment. > Thank you for working on this! This should also include test coverage (hmmm, > we don't have a reasonable way to lit test performance regressions though > so perhaps we just need to ensure there's at least one test that would > normally have been unreasonably

[PATCH] D130791: [clang] Short-circuit trivial constexpr array constructors

aaron.ballman added a comment. Thank you for working on this! This should also include test coverage (hmmm, we don't have a reasonable way to lit test performance regressions though so perhaps we just need to ensure there's at least one test that would normally have been unreasonably

[PATCH] D130791: [clang] Short-circuit trivial constexpr array constructors

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, rsmith. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As discussed in https://github.com/llvm/llvm-project/issues/56774