[PATCH] D130863: [clangd] Make git ignore index directories

sammccall added a comment. @sums I think this just needs minor comments addressed and can be landed. Are you still interested in finishing it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130863/new/ https://reviews.llvm.org/D130863

[PATCH] D130863: [clangd] Make git ignore index directories

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp:58 +if (CreatingNewDirectory) { + llvm::Error error = addGitignore(DiskShardRoot); + if (error) { nit: ``` if(llvm::Error E = addGitignore(..)) {

[PATCH] D130863: [clangd] Make git ignore index directories

kadircet added a comment. In D130863#3696419 , @sums wrote: > Thank you for the reviews and discussion, everyone! > > TIL about `.git/info/exclude`. It'll let me exclude stuff without updating > the checked in `.gitignore`. I was achieving the same

[PATCH] D130863: [clangd] Make git ignore index directories

sums marked an inline comment as done. sums added a comment. Thank you for the reviews and discussion, everyone! TIL about `.git/info/exclude`. It'll let me exclude stuff without updating the checked in `.gitignore`. I was achieving the same effect for clangd by manually creating a

[PATCH] D130863: [clangd] Make git ignore index directories

ilya-biryukov added a comment. In D130863#3693293 , @sammccall wrote: > In D130863#3693135 , @ilya-biryukov > wrote: > >> Otherwise, I would personally still put `.cache/clangd` into the global >> `.gitignore`

[PATCH] D130863: [clangd] Make git ignore index directories

sammccall added a comment. In D130863#3693135 , @ilya-biryukov wrote: > Otherwise, I would personally still put `.cache/clangd` into the global > `.gitignore` or `.git/info/exclude`. IMO `.cache/clangd` should not be in the > VCS history at all, even

[PATCH] D130863: [clangd] Make git ignore index directories

ilya-biryukov added a comment. I'm with Kadir on this one, but maybe I'm too attached to my `.git/info/exclude`s. I somehow don't feel it's a big burden specific to clangd. I have to configure `.gitignore` for my projects and `.git/info/excludes` for other projects I work on because of many

[PATCH] D130863: [clangd] Make git ignore index directories

sums marked an inline comment as done. sums added inline comments. Comment at: clang-tools-extra/clangd/test/background-index.test:23 +# RUN: ls %/t/.cache/clangd/index/.gitignore +# RUN: ls %/t/sub_dir/.cache/clangd/index/.gitignore + sammccall wrote: > Bleh,

[PATCH] D130863: [clangd] Make git ignore index directories

sammccall added a comment. My 2c, though I'm away with kids right now so will leave to @kadircet to make a call Given that this is fully contained (logically and physically) within clangd's index directory, this seems elegant and harmless to me. (At first i thought it was modifying

[PATCH] D130863: [clangd] Make git ignore index directories

sums added a comment. In D130863#3690275 , @kadircet wrote: > I am not sure if clangd is the right tool the create those `.gitignore` > files, e.g. what if the project's VCS isn't git? I believe the right thing to > do is for projects that want to make

[PATCH] D130863: [clangd] Make git ignore index directories

kadircet added a comment. I am not sure if clangd is the right tool the create those `.gitignore` files, e.g. what if the project's VCS isn't git? I believe the right thing to do is for projects that want to make use of such tools to ignore the relevant directory explicitly (e.g. `.cache).

[PATCH] D130863: [clangd] Make git ignore index directories

sums created this revision. sums added a reviewer: clang-tools-extra. sums added a project: clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. sums requested review of this revision. Herald added subscribers: cfe-commits, MaskRay,