[PATCH] D130933: Add docs for function attributes hot/cold

aaron.ballman added a comment. In D130933#3713437 , @OfekShilon wrote: > @aaron.ballman 'Ofek Shilon', ofekshi...@gmail.com is fine. > Thanks! Thank you! I've landed on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130933: Add docs for function attributes hot/cold

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73a1b162a4cd: Add docs for function attributes hot/cold (authored by OfekShilon, committed by aaron.ballman). Repository: rG LLVM Github Monorepo

[PATCH] D130933: Add docs for function attributes hot/cold

OfekShilon added a comment. @aaron.ballman 'Ofek Shilon', ofekshi...@gmail.com is fine. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130933/new/ https://reviews.llvm.org/D130933 ___ cfe-commits mailing list

[PATCH] D130933: Add docs for function attributes hot/cold

aaron.ballman accepted this revision. aaron.ballman added a comment. In D130933#3713277 , @OfekShilon wrote: > My apologies for the mess, hopefully the diff I just uploaded includes all > the right fixes. No worries! If I had a nickel for every time

[PATCH] D130933: Add docs for function attributes hot/cold

OfekShilon updated this revision to Diff 451535. OfekShilon added a comment. My apologies for the mess, hopefully the diff I just uploaded includes all the right fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130933/new/ https://reviews.llvm.org/D130933 Files:

[PATCH] D130933: Add docs for function attributes hot/cold

aaron.ballman added a comment. I'm not a git expert by any means, but you might be able to address the patch issues with `git diff -U999 main > foo.patch` from the root llvm-project directory so that you're getting a diff with 999 lines of context and the differences are against the `main`

[PATCH] D130933: Add docs for function attributes hot/cold

OfekShilon added a comment. > It looks like something might have gone wrong because the diff looks like > it's now a diff against something other than the main branch (it looks like > it's adding the SimpleHandler lines in Attr.td, but those lines already exist > in main). Sorry about that,

[PATCH] D130933: Add docs for function attributes hot/cold

aaron.ballman added a comment. In D130933#3710682 , @OfekShilon wrote: > Addressed Aaron's comments (thanks!). Hope I got the update-diff procedure > right. It looks like something might have gone wrong because the diff looks like it's now a diff

[PATCH] D130933: Add docs for function attributes hot/cold

OfekShilon updated this revision to Diff 451237. OfekShilon added a comment. Addressed Aaron's comments (thanks!). Hope I got the update-diff procedure right. I don't have commit permissions, would appreciate if someone could push this. CHANGES SINCE LAST ACTION

[PATCH] D130933: Add docs for function attributes hot/cold

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. LGTM from the content point of view. Please also address aaron's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130933/new/

[PATCH] D130933: Add docs for function attributes hot/cold

aaron.ballman added a comment. Thank you for adding the docs! I'm not well-versed enough in hot/cold behavior and PGO to comment on the documentation accuracy, so I'm hopeful someone can sign off on that bit. Comment at: clang/include/clang/Basic/Attr.td:1077 - let

[PATCH] D130933: Add docs for function attributes hot/cold

OfekShilon created this revision. OfekShilon added reviewers: xur, davidxl. Herald added a reviewer: aaron.ballman. Herald added a project: All. OfekShilon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Following this