[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

erichkeane added a comment. In D131007#3699162 , @aaron.ballman wrote: > In D131007#3699142 , @omjavaid > wrote: > >> This breaks clang causes it to crash in LLDB buildbot testsuite breaking the >> LLDB

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

aaron.ballman added a comment. In D131007#3699142 , @omjavaid wrote: > This breaks clang causes it to crash in LLDB buildbot testsuite breaking the > LLDB buildbot: https://lab.llvm.org/buildbot/#/builders/96/builds/27003 I believe this was already

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

omjavaid added a comment. This breaks clang causes it to crash in LLDB buildbot testsuite breaking the LLDB buildbot: https://lab.llvm.org/buildbot/#/builders/96/builds/27003 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131007/new/

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

erichkeane added a comment. In D131007#3696495 , @erichkeane wrote: > In D131007#3696489 , @erichkeane > wrote: > >> In D131007#3696486 , @labath wrote: >> >>> This

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

erichkeane added a comment. In D131007#3696489 , @erichkeane wrote: > In D131007#3696486 , @labath wrote: > >> This seems to break lldb tests, specifically the compilation of this >>

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

erichkeane added a comment. In D131007#3696486 , @labath wrote: > This seems to break lldb tests, specifically the compilation of this > > source file.

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

labath added a comment. This seems to break lldb tests, specifically the compilation of this source file. The compile fails with an assertion (`Keyword not known to come from a newer Standard

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb65b17932e1: [NFCI] Refactor how KeywordStatus is calculated (authored by erichkeane). Herald added a project: clang. Changed prior to commit:

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

erichkeane added a comment. In D131007#3694684 , @tahonermann wrote: > Accepting again. New changes suggested by Aaron are a clear improvement. > Except maybe for the rename of `LSB` to `LSSB`. `LSSB` is what? Low-Speed > Serial Bus? Law School

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

tahonermann accepted this revision. tahonermann added a comment. Accepting again. New changes suggested by Aaron are a clear improvement. Except maybe for the rename of `LSB` to `LSSB`. `LSSB` is what? Low-Speed Serial Bus? Law School Student Body? Lone Star Symphonic Band? Maybe just call it

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

erichkeane updated this revision to Diff 449404. erichkeane added a comment. Add underlying type to TokenKey, plus did all of Aaron's review comments. In general, I think we dont' have a good definition of Extension vs Enabled here, and someone should probably think that through. I'll review

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM once nits are fixed (take or leave them). Comment at: clang/lib/Basic/IdentifierTable.cpp:169 + case KEYALTIVEC: +return LangOpts.AltiVec ? KS_Enabled : KS_Unknown; + case KEYBORLAND:

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

erichkeane marked 3 inline comments as done. erichkeane added inline comments. Comment at: clang/lib/Basic/IdentifierTable.cpp:169 + case KEYALTIVEC: +return LangOpts.AltiVec ? KS_Enabled : KS_Unknown; + case KEYBORLAND: aaron.ballman wrote: > Should this

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. I think this looks good. It took me a while to appreciate the new approach; I miss some of the compactness of the previous presentation, but this approach looks more likely to

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:400-401 +CXX20_KEYWORD(concept , 0) +CXX20_KEYWORD(requires , 0) // Not a CXX20_KEYWORD because it is disabled by -fno-char8_t. KEYWORD(char8_t

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

erichkeane created this revision. erichkeane added reviewers: aaron.ballman, tahonermann, shafik, Codesbyusman. Herald added a project: All. erichkeane requested review of this revision. The getKeywordStatus function is a horrible mess of inter-dependent 'if' statements that depend significantly