[PATCH] D131057: [Sema] -Wformat: support C23 printf %b %B

2022-08-03 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D131057#3697265 , @enh wrote: >> I think making scanf in the same patch makes sense. Let me check existing >> tests... > > fwiw, most of the libcs seem to have been doing these separately because > scanf is harder. i

[PATCH] D131057: [Sema] -Wformat: support C23 printf %b %B

2022-08-03 Thread Elliott Hughes via Phabricator via cfe-commits
enh added a comment. > I think making scanf in the same patch makes sense. Let me check existing > tests... fwiw, most of the libcs seem to have been doing these separately because scanf is harder. i hope to have bionic's scanf done this week though. (note in case you haven't already that

[PATCH] D131057: [Sema] -Wformat: support C23 printf %b %B

2022-08-03 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D131057#3697165 , @aaron.ballman wrote: > Thanks for working on this! Please also add a release note for it. Will add:) > I think there are changes missing for ScanfFormatString.cpp to handle `bArg` > and `BArg` that

[PATCH] D131057: [Sema] -Wformat: support C23 printf %b %B

2022-08-03 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Thanks for working on this! Please also add a release note for it. I think there are changes missing for ScanfFormatString.cpp to handle `bArg` and `BArg` that should be handled at the same time. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D131057: [Sema] -Wformat: support C23 printf %b %B

2022-08-03 Thread Elliott Hughes via Phabricator via cfe-commits
enh accepted this revision. enh added a comment. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131057/new/ https://reviews.llvm.org/D131057 ___ cfe-commits mailing list

[PATCH] D131057: [Sema] -Wformat: support C23 printf %b %B

2022-08-03 Thread Dimitry Andric via Phabricator via cfe-commits
dim added a comment. > GCC 12 -Wformat -pedantic emits a warning: > > warning: ISO C17 does not support the ‘%b’ gnu_printf format [-Wformat=] > > The behavior is not ported (and it's unclear to me how to implement it). If you really want this, I think it can be implemented by looking at

[PATCH] D131057: [Sema] -Wformat: support C23 printf %b %B

2022-08-03 Thread Dimitry Andric via Phabricator via cfe-commits
dim accepted this revision. dim added a subscriber: emaste. dim added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131057/new/ https://reviews.llvm.org/D131057

[PATCH] D131057: [Sema] -Wformat: support C23 printf %b %B

2022-08-03 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: aaron.ballman, dim, enh, erik.pilkington. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Close #56885. %b