[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bd2b2dce2a9: Add support for specifying the severity of a SARIF Result (authored by vaibhav.y, committed by aaron.ballman). Repository: rG LLVM

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y added a comment. Thank you! I don't have merge access, will need your help for that :) For the commit details, I'd like to use: - Name: Vaibhav Yenamandra - email address: vyenaman...@bloomberg.net Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131084/new/ https://reviews.llvm.org/D131084 ___ cfe-commits mailing list

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y updated this revision to Diff 453427. vaibhav.y edited the summary of this revision. vaibhav.y added a comment. Address review comments: - Drop include line that added `llvm/Support/ErrorHandling.h` - Use `llvm::Optional::value_or(...)` instead of bare conditional - Add

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y marked 4 inline comments as done. vaibhav.y added inline comments. Comment at: clang/include/clang/Basic/Sarif.h:157 +/// 1. https://docs.oasis-open.org/sarif/sarif/v2.1.0/os/sarif-v2.1.0-os.html#_Toc34317648;>level property +enum class SarifResultLevel { Note,

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Sarif.h:157 +/// 1. https://docs.oasis-open.org/sarif/sarif/v2.1.0/os/sarif-v2.1.0-os.html#_Toc34317648;>level property +enum class SarifResultLevel { Note, Warning, Error }; + vaibhav.y

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y marked an inline comment as not done. vaibhav.y added inline comments. Comment at: clang/include/clang/Basic/Sarif.h:157 +/// 1. https://docs.oasis-open.org/sarif/sarif/v2.1.0/os/sarif-v2.1.0-os.html#_Toc34317648;>level property +enum class SarifResultLevel { Note,

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Sarif.h:157 +/// 1. https://docs.oasis-open.org/sarif/sarif/v2.1.0/os/sarif-v2.1.0-os.html#_Toc34317648;>level property +enum class SarifResultLevel { Note, Warning, Error }; + Should

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y updated this revision to Diff 451635. vaibhav.y added a comment. Run git-clang-format Rebase on upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131084/new/ https://reviews.llvm.org/D131084 Files:

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y updated this revision to Diff 451633. vaibhav.y added a comment. Autofix clang-tidy readability warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131084/new/ https://reviews.llvm.org/D131084 Files:

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y added inline comments. Comment at: clang/include/clang/Basic/Sarif.h:256 std::string HelpURI; + SarifReportingConfiguration DefaultConfiguration; Is this form preferred for expressing a statically known default value? Repository: rG LLVM

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y updated this revision to Diff 451585. vaibhav.y added a comment. Update diff: - Create class `SarifReportingConfiguration`: This should allow rules to specify the `defaultConfiguration` property Add tests for: - Creating rules with custom reporting configuration - Death test for

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

abrahamcd added a comment. In D131084#3697211 , @vaibhav.y wrote: > Submitting for review: > > Some notes: > > There are a couple of ways I think we can acheive this, per the spec: > > 1. The reportingDescriptor (rule) objects can be given a default >

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y added a comment. > A part of my endgame is to see notes be incorporated into their parents, but > that's a long way off methinks. Regarding this, the current best approach the spec provides is using the "locationRelationShip"

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

cjdb added a subscriber: Naghasan. cjdb added a comment. In D131084#3699223 , @aaron.ballman wrote: > In D131084#3697678 , @cjdb wrote: > >> It seems I got confused and conflated the two this morning. >> >> In

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

aaron.ballman added a comment. In D131084#3697678 , @cjdb wrote: > It seems I got confused and conflated the two this morning. > > In D131084#3697525 , @vaibhav.y > wrote: > >>> Hmm, we can probably use

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

cjdb added a comment. It seems I got confused and conflated the two this morning. In D131084#3697525 , @vaibhav.y wrote: >> Hmm, we can probably use "informational" for notes, warnings, and remarks, >> but I'm kinda partial to proposing the latter two

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y added a comment. > Hmm, we can probably use "informational" for notes, warnings, and remarks, > but I'm kinda partial to proposing the latter two upstream. Interesting, I agree that remarks could fit under "informational". As for notes: As I understand it they are always child

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

denik added a comment. In D131084#3697256 , @cjdb wrote: > In D131084#3697211 , @vaibhav.y > wrote: > >> Submitting for review: >> >> Some notes: >> >> There are a couple of ways I think we can acheive this, per

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

cjdb added a comment. In D131084#3697211 , @vaibhav.y wrote: > Submitting for review: > > Some notes: > > There are a couple of ways I think we can acheive this, per the spec: > > 1. The reportingDescriptor (rule) objects can be given a default >

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y created this revision. vaibhav.y added reviewers: aaron.ballman, cjdb, denik, abrahamcd, dbeer1. Herald added a project: All. vaibhav.y edited the summary of this revision. vaibhav.y edited the summary of this revision. vaibhav.y updated this revision to Diff 449713. vaibhav.y added a