[PATCH] D131213: [clang][Headers] Fix unintentional error in D130800

aaron.ballman added a comment. In D131213#3702707 , @iana wrote: > In D131213#3702699 , @ddcc wrote: > >> I missed line 19, yeah that makes sense. @iana is that ok with you? > > Ah, I didn't see that either. Can

[PATCH] D131213: [clang][Headers] Fix unintentional error in D130800

iana added a comment. In D131213#3702699 , @ddcc wrote: > I missed line 19, yeah that makes sense. @iana is that ok with you? Ah, I didn't see that either. Can we just lose the `defined` on line 26 then? It's redundant and little confusing.

[PATCH] D131213: [clang][Headers] Fix unintentional error in D130800

ddcc added a comment. I missed line 19, yeah that makes sense. @iana is that ok with you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131213/new/ https://reviews.llvm.org/D131213 ___ cfe-commits

[PATCH] D131213: [clang][Headers] Fix unintentional error in D130800

aaron.ballman added a comment. > Undefined macros evaluate to zero, so when checking for a smaller value, we > need to include the case when the macro is undefined. The code being changed already checks `defined(__cplusplus)` so there no undefined macro value being tested. What's more, if

[PATCH] D131213: [clang][Headers] Fix unintentional error in D130800

iana accepted this revision. iana added a comment. This revision is now accepted and ready to land. That was the only one I saw from D130800 , can someone double check me though? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131213: [clang][Headers] Fix unintentional error in D130800

ddcc created this revision. ddcc added reviewers: aaron.ballman, iana. Herald added a project: All. ddcc requested review of this revision. Herald added a project: clang. Undefined macros evaluate to zero, so when checking for a smaller value, we need to include the case when the macro is