[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

This revision was automatically updated to reflect the committed changes. Closed by commit rG06fc5a771462: Driver: Refactor and support per target dirs in baremetal (authored by manojgupta). Changed prior to commit: https://reviews.llvm.org/D131225?vs=451352=451517#toc Repository: rG LLVM

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added a comment. Still LGTM Comment at: clang/lib/Driver/ToolChains/BareMetal.h:2 +//===--- BareMetal.h - Bare Metal Tool and ToolChain -*- C++ +//-*-===// // Line overflowed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

manojgupta updated this revision to Diff 451352. manojgupta added a comment. Going back to older handlesTarget() style in Baremetal. Apparently RISCV can be both Baremetal or RISCVToolchain for the same tuple. I do not know of the nuances so trying not to disturb that for now. Repository: rG

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

manojgupta updated this revision to Diff 451325. manojgupta added a comment. Fix clang-format complains. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131225/new/ https://reviews.llvm.org/D131225 Files: clang/lib/Driver/Driver.cpp

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

manojgupta updated this revision to Diff 451222. manojgupta added a comment. Address maskray comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131225/new/ https://reviews.llvm.org/D131225 Files: clang/lib/Driver/Driver.cpp

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/lib/Support/Triple.cpp:1938 +return false; + + if (getVendor() != UnknownVendor) The prevailing style doesn't add a blank line for every `if` statement.

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

manojgupta added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:228-237 + case ToolChain::RLT_CompilerRT: { +const std::string fileName = getCompilerRT(Args, "builtins"); +std::string baseName = llvm::sys::path::filename(fileName).str(); +

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

manojgupta updated this revision to Diff 450910. manojgupta added a comment. Address more style lints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131225/new/ https://reviews.llvm.org/D131225 Files: clang/lib/Driver/Driver.cpp

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added a comment. In D131225#3707735 , @manojgupta wrote: > Address style nits. Neat, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131225/new/ https://reviews.llvm.org/D131225

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

manojgupta updated this revision to Diff 450908. manojgupta added a comment. Address style nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131225/new/ https://reviews.llvm.org/D131225 Files: clang/lib/Driver/Driver.cpp

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added inline comments. Comment at: llvm/lib/Support/Triple.cpp:1936 +bool Triple::isARMBareMetal() const { + if (getArch() != llvm::Triple::arm && getArch() != Triple::thumb) +return false; (nit) at least `llvm::` qualification is redundant,

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 accepted this revision. barannikov88 added a comment. This revision is now accepted and ready to land. LGTM with the style issues fixed, but I'd like someone else to take a look. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:228-237 + case

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

manojgupta updated this revision to Diff 450898. manojgupta added a comment. Herald added a subscriber: hiraditya. Moved defs to Triple.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131225/new/ https://reviews.llvm.org/D131225 Files:

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added inline comments. Comment at: llvm/include/llvm/ADT/Triple.h:916 + /// Tests if the target is {arm,thumb}-none-none-{eabi,eabihf}. + bool isARMBareMetal() const { +if (getArch() != Triple::arm && getArch() != Triple::thumb) Any future

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

manojgupta added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:388 + /// IsRISCVBareMetal - Does this tool chain is a riscv baremetal target. + static bool IsRISCVBareMetal(const llvm::Triple &); + barannikov88 wrote: > barannikov88

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:388 + /// IsRISCVBareMetal - Does this tool chain is a riscv baremetal target. + static bool IsRISCVBareMetal(const llvm::Triple &); + barannikov88 wrote: > manojgupta

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

manojgupta updated this revision to Diff 450894. manojgupta added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Moved Baremetal triple related code to Triple.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:388 + /// IsRISCVBareMetal - Does this tool chain is a riscv baremetal target. + static bool IsRISCVBareMetal(const llvm::Triple &); + manojgupta wrote: > barannikov88

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

manojgupta added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:384 + /// IsBareMetal - Does this tool chain is a baremetal target. + static bool IsBareMetal(const llvm::Triple &); barannikov88 wrote: > Is this a correct sentence? (My

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

abidh added a comment. In D131225#3706239 , @barannikov88 wrote: > In D131225#3706207 , @abidh wrote: > >> I think this patch is moving the things in the right direction. But please >> wait for some other

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added a comment. In D131225#3706207 , @abidh wrote: > I think this patch is moving the things in the right direction. But please > wait for some other reviewers to chime in. It seems quite opposite to me. Comment at:

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

abidh added a comment. I think this patch is moving the things in the right direction. But please wait for some other reviewers to chime in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131225/new/ https://reviews.llvm.org/D131225

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

manojgupta created this revision. manojgupta added reviewers: MaskRay, abidh, kristof.beyls. Herald added subscribers: luke957, StephenFan, s.egerton, simoncook, ki.stfu. Herald added a project: All. manojgupta requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead.