[PATCH] D131314: [clang] format string checks for `InitListExpr`

aaron.ballman added a comment. In D131314#3710514 , @inclyc wrote: > In D131314#3710331 , @aaron.ballman > wrote: > >> In D131314#3707131 , @inclyc wrote: >> >>> ping >>

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc added a comment. In D131314#3710331 , @aaron.ballman wrote: > In D131314#3707131 , @inclyc wrote: > >> ping > > FWIW, we usually only ping a review that hasn't had any activity in a week or > more (it's

[PATCH] D131314: [clang] format string checks for `InitListExpr`

aaron.ballman added a comment. In D131314#3707131 , @inclyc wrote: > ping FWIW, we usually only ping a review that hasn't had any activity in a week or more (it's not uncommon for reviews to sit for a few days while people think about them or

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131314/new/ https://reviews.llvm.org/D131314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc updated this revision to Diff 450569. inclyc added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131314/new/ https://reviews.llvm.org/D131314 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc updated this revision to Diff 450530. inclyc added a comment. rebase && qualify `const` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131314/new/ https://reviews.llvm.org/D131314 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc updated this revision to Diff 450528. inclyc added a comment. Use isa<> to check Expr class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131314/new/ https://reviews.llvm.org/D131314 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc added a comment. There are too many things changed in this patch, I think the function of displaying the evaluation results, `FIXME` warning, these can be done in subsequent patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131314: [clang] format string checks for `InitListExpr`

tbaeder added a comment. Not a formal review of course, but for the diagnostics, I'm missing something that tells the user what the format string ended up looking like; in your example, the output never mentions that it checked "%s%d". Comment at:

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc updated this revision to Diff 450496. inclyc added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131314/new/ https://reviews.llvm.org/D131314 Files: clang/lib/Sema/SemaChecking.cpp clang/test/SemaCXX/format-strings.cpp

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc updated this revision to Diff 450495. inclyc added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131314/new/ https://reviews.llvm.org/D131314 Files: clang/lib/Sema/SemaChecking.cpp clang/test/SemaCXX/format-strings.cpp

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc updated this revision to Diff 450494. inclyc added a comment. typo fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131314/new/ https://reviews.llvm.org/D131314 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc created this revision. Herald added a project: All. inclyc added reviewers: aaron.ballman, rsmith, mizvekov, tbaeder. inclyc added a project: clang. inclyc added a subscriber: clang. inclyc published this revision for review. Herald added a subscriber: cfe-commits. this patch enhances