[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbce94ea551ae: [OMPIRBuilder] Add support for safelen clause (authored by psoni2628). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

psoni2628 updated this revision to Diff 453745. psoni2628 added a comment. - Simplify expression based on reviewer comments - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131526/new/ https://reviews.llvm.org/D131526 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3042 + + if (!(Simdlen == nullptr && Safelen == nullptr)) { +// If both simdlen and safelen clauses

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

shraiysh added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:625 + void applySimd(CanonicalLoopInfo *Loop, Value *IfCond, ConstantInt *Simdlen, + ConstantInt *Safelen); psoni2628 wrote: > shraiysh wrote: > >

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

psoni2628 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:625 + void applySimd(CanonicalLoopInfo *Loop, Value *IfCond, ConstantInt *Simdlen, + ConstantInt *Safelen); shraiysh wrote: > [nit] Please set the

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

shraiysh added a comment. Minor comments. Thank you for working on this! Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:625 + void applySimd(CanonicalLoopInfo *Loop, Value *IfCond, ConstantInt *Simdlen, + ConstantInt *Safelen);

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

psoni2628 updated this revision to Diff 451500. psoni2628 added a comment. - Add LoopMDList CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131526/new/ https://reviews.llvm.org/D131526 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/irbuilder_safelen.cpp

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

Meinersbur added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3029-3032 +addLoopMetadata( +CanonicalLoop, +MDNode::get(Ctx, {MDString::get(Ctx, "llvm.loop.parallel_accesses"), + AccessGroup}));

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

psoni2628 updated this revision to Diff 451449. psoni2628 added a comment. - Add comments based on reviewer's feedback - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131526/new/ https://reviews.llvm.org/D131526 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

arnamoy10 added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3045 + if (!(Simdlen == nullptr && Safelen == nullptr)) { +ConstantInt *VectorizeWidth = Simdlen == nullptr ? Safelen : Simdlen; addLoopMetadata( psoni2628 wrote: >

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

psoni2628 added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3045 + if (!(Simdlen == nullptr && Safelen == nullptr)) { +ConstantInt *VectorizeWidth = Simdlen == nullptr ? Safelen : Simdlen; addLoopMetadata( domada wrote: >

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

domada added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2598 for (OMPClause *C : S.clauses()) { // Currently only simdlen clause is supported +if (!(isa(C) || isa(C))) Could you update this comment? Comment at: