[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9babe757160: [OpenMP] Clang Support for taskwait nowait clause (authored by koops, committed by cchen). Repository: rG LLVM Github Monorepo

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

ABataev accepted this revision. ABataev added a comment. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131830/new/ https://reviews.llvm.org/D131830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

koops updated this revision to Diff 484290. koops added a comment. Taking care of : 1. "The nowait clause may only appear on a taskwait directive if the depend clause is present.". 2. "Please do not add any new tests using -no-opaque-pointers". 3. Added a new test to expect failure for point 1.

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

nikic added inline comments. Comment at: clang/test/OpenMP/taskwait_depend_nowait_codegen.cpp:1 +// RUN: %clang_cc1 -no-opaque-pointers -verify -triple x86_64-apple-darwin10 -fopenmp -fopenmp-version=51 -x c++ -emit-llvm %s -o - | FileCheck %s +// RUN: %clang_cc1

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

protze.joachim added a comment. Why do we need __kmpc_omp_taskwait_51 ? Taskwait nowait only makes sense with dependencies. It should only result in additional nodes/edges in the task dependency graph without any code to execute. There is not taskwait (aka task barrier) in this case. The

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

mstorsjo added a comment. In D131830#3986436 , @koops wrote: >> (There seems to be another unrelated regression at the same time though, >> regarding the symbol __kmpc_fork_call_if.) > > I do not know about this regression. I have not touched this

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

koops added a comment. > (There seems to be another unrelated regression at the same time though, > regarding the symbol __kmpc_fork_call_if.) I do not know about this regression. I have not touched this function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131830/new/

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

mstorsjo added a comment. In D131830#3985449 , @koops wrote: > Martin Storsjö (or anybody who works on windows) I have uploaded a new patch > which has __kmpc_omp_taskwait_51 in dllexports. Can you please check the > patch on windows? Thanks, now this

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

koops updated this revision to Diff 481742. koops added a comment. git pull & reloading the earlier patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131830/new/ https://reviews.llvm.org/D131830 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

koops added a comment. mstorsjo, I have uploaded a new patch which has __kmpc_omp_taskwait_51 in dllexports. Can you please check the patch on windows? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131830/new/ https://reviews.llvm.org/D131830

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

koops updated this revision to Diff 481740. koops added a comment. Addition of __kmpc_omp_taskwait_51 in dllexports. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131830/new/ https://reviews.llvm.org/D131830 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

mstorsjo added inline comments. Comment at: openmp/runtime/src/dllexports:348 __kmpc_omp_wait_deps243 +__kmpc_omp_taskwait_deps_51 292 __kmpc_cancel 244 This is missing a similar export of

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG100dfe7a8ad3: [OpenMP] Clang Support for taskwait nowait clause (authored by koops, committed by ABataev). Herald added projects: clang, OpenMP.