[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc526e346deb: [C++20] [Coroutines] Disable to take the address of labels in coroutines (authored by ChuanqiXu). Changed prior to commit: https://reviews.llvm.org/D131938?vs=452925=489677#toc

[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Oh, sorry, I forgot this. Given D132084 is not updated recently, I think we can merge this first. And it should be fine to remove this one after

[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

avogelsgesang added a comment. Personally, I am fine with this change as in review right now. @ychen are you still planning to look further into this issue as part of your alternative patch https://reviews.llvm.org/D132084 ? Otherwise, I would propose that we merge @ChuanqiXu 's change for the

[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

ChuanqiXu added a comment. In D131938#3727954 , @ychen wrote: >> Since the coroutines are going to split into pieces in the middle end so the >> address of labels are ambiguous that time. > > Do we split in the middle or copy the whole computed goto

[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

ychen added a comment. > Since the coroutines are going to split into pieces in the middle end so the > address of labels are ambiguous that time. Do we split in the middle or copy the whole computed goto CFG? I'd imagine the branch on a dynamic block address is like `n`-way branch which is

[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

ChuanqiXu updated this revision to Diff 452925. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131938/new/ https://reviews.llvm.org/D131938 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

avogelsgesang added a comment. looks good to me on a high-level, but I don't know clang well enough to confidently approve this change Comment at: clang/lib/Sema/SemaCoroutine.cpp:1107 + + // Corotuines will get splitted into pieces. The GNU address of label + // extension

[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

ChuanqiXu updated this revision to Diff 452880. ChuanqiXu added a comment. Add ReleaseNotes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131938/new/ https://reviews.llvm.org/D131938 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

ChuanqiXu created this revision. ChuanqiXu added reviewers: aaron.ballman, erichkeane, ychen, avogelsgesang. ChuanqiXu added a project: clang. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. Closing