[PATCH] D131963: [libc++] Add custom clang-tidy checks

2022-12-23 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added inline comments. Comment at: libcxx/test/libcxx/clang_tidy.sh.cpp:15 // TODO: run clang-tidy with modules enabled once they are supported +// RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* --checks='-*,libcpp-*'

[PATCH] D131963: [libc++] Add custom clang-tidy checks

2022-11-24 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. Herald added a reviewer: njames93. Let's make those checks optional until we can figure out the packaging stuff, and land this (with green CI). This is going to become way too stale otherwise. Comment at:

[PATCH] D131963: [libc++] Add custom clang-tidy checks

2022-10-10 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. In D131963#3845092 , @philnik wrote: > In D131963#3831786 , @smeenai wrote: > >> In D131963#3811811 , @ldionne >> wrote: >> >>> I'd be fine with

[PATCH] D131963: [libc++] Add custom clang-tidy checks

2022-10-08 Thread Nikolas Klauser via Phabricator via cfe-commits
philnik added a comment. In D131963#3831786 , @smeenai wrote: > In D131963#3811811 , @ldionne wrote: > >> I'd be fine with this as-is if it works in the CI. >> >> IIUC, the current blocker for this is that the

[PATCH] D131963: [libc++] Add custom clang-tidy checks

2022-10-03 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. In D131963#3811811 , @ldionne wrote: > I'd be fine with this as-is if it works in the CI. > > IIUC, the current blocker for this is that the `ClangConfig.cmake` installed > by LLVM is not robust to the dev packages missing. If

[PATCH] D131963: [libc++] Add custom clang-tidy checks

2022-09-30 Thread Jonathan Wakely via Phabricator via cfe-commits
jwakely added inline comments. Comment at: libcxx/test/tools/clang_tidy_checks/robust_against_adl.cpp:22 +AST_MATCHER(clang::UnresolvedLookupExpr, isCustomizationPoint) { + // TODO: Are make_error_code and make_error_condition actually customization points? + return

[PATCH] D131963: [libc++] Add custom clang-tidy checks

2022-09-25 Thread Jonathan Wakely via Phabricator via cfe-commits
jwakely added inline comments. Comment at: libcxx/test/tools/clang_tidy_checks/robust_against_adl.cpp:22 +AST_MATCHER(clang::UnresolvedLookupExpr, isCustomizationPoint) { + // TODO: Are make_error_code and make_error_condition actually customization points? + return

[PATCH] D131963: [libc++] Add custom clang-tidy checks

2022-09-25 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a subscriber: jwakely. Mordante added inline comments. Comment at: libcxx/test/tools/clang_tidy_checks/robust_against_adl.cpp:22 +AST_MATCHER(clang::UnresolvedLookupExpr, isCustomizationPoint) { + // TODO: Are make_error_code and make_error_condition actually

[PATCH] D131963: [libc++] Add custom clang-tidy checks

2022-09-23 Thread Louis Dionne via Phabricator via cfe-commits
ldionne accepted this revision. ldionne added subscribers: smeenai, beanz. ldionne added a comment. This revision is now accepted and ready to land. I'd be fine with this as-is if it works in the CI. IIUC, the current blocker for this is that the `ClangConfig.cmake` installed by LLVM is not