[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d8ddf53cc80: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit (authored by yubing). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

yubing updated this revision to Diff 455041. yubing added a comment. address sign-conversion issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files: clang/lib/Headers/immintrin.h

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07e34763b027: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit (authored by yubing). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

yubing updated this revision to Diff 454738. yubing added a comment. Execute the second rdrand32 despite of whether the first one fail or not Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files:

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

RKSimon added inline comments. Comment at: clang/lib/Headers/immintrin.h:301 + unsigned long long tmp; + if (__builtin_ia32_rdrand32_step((unsigned int *)) & + __builtin_ia32_rdrand32_step(((unsigned int *)) + 1)) { yubing wrote: > RKSimon wrote: > >

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

yubing added inline comments. Comment at: clang/lib/Headers/immintrin.h:301 + unsigned long long tmp; + if (__builtin_ia32_rdrand32_step((unsigned int *)) & + __builtin_ia32_rdrand32_step(((unsigned int *)) + 1)) { RKSimon wrote: > RKSimon wrote: > >

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

RKSimon added inline comments. Comment at: clang/lib/Headers/immintrin.h:301 + unsigned long long tmp; + if (__builtin_ia32_rdrand32_step((unsigned int *)) & + __builtin_ia32_rdrand32_step(((unsigned int *)) + 1)) { RKSimon wrote: > craig.topper wrote: >

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

yubing updated this revision to Diff 454357. yubing added a comment. address craig's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files: clang/lib/Headers/immintrin.h

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

craig.topper added inline comments. Comment at: clang/lib/Headers/immintrin.h:300 +{ + unsigned int lo, hi; + if (__builtin_ia32_rdrand32_step() && __builtin_ia32_rdrand32_step()) { craig.topper wrote: > variable names in intrinsic headers must start with 2

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

yubing updated this revision to Diff 454356. yubing added a comment. address simon's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files: clang/lib/Headers/immintrin.h

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

craig.topper added inline comments. Comment at: clang/lib/Headers/immintrin.h:300 +{ + unsigned int lo, hi; + if (__builtin_ia32_rdrand32_step() && __builtin_ia32_rdrand32_step()) { variable names in intrinsic headers must start with 2 underscores.

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/rdrand-builtins.c:20 #if __x86_64__ int rdrand64(unsigned long long *p) { why do you still need the #if-else-endif? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

yubing updated this revision to Diff 453866. yubing added a comment. fix a small issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files: clang/lib/Headers/immintrin.h

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

yubing updated this revision to Diff 453865. yubing added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files: clang/lib/Headers/immintrin.h

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

RKSimon added inline comments. Comment at: clang/lib/Headers/immintrin.h:301 + unsigned long long tmp; + if (__builtin_ia32_rdrand32_step((unsigned int *)) & + __builtin_ia32_rdrand32_step(((unsigned int *)) + 1)) { craig.topper wrote: > craig.topper

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

craig.topper added inline comments. Comment at: clang/lib/Headers/immintrin.h:301 + unsigned long long tmp; + if (__builtin_ia32_rdrand32_step((unsigned int *)) & + __builtin_ia32_rdrand32_step(((unsigned int *)) + 1)) { Should `&` be `&&`?

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

yubing created this revision. Herald added a subscriber: pengfei. Herald added a project: All. yubing requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D132141 Files: