[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

2022-08-24 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0a4c6c9f98a6: [clang] Allow using -rtlib=platform to switching to the default rtlib on all… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

2022-08-24 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM In D132444#3743051 , @mstorsjo wrote: > In D132444#3743020 , @thakis wrote: > >> Makes sense to me.

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

2022-08-23 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D132444#3743020 , @thakis wrote: > Makes sense to me. Maybe @hans has an opinion too. > > WDYT about accepting the same string for -fuse-ld= to mean "platform linker" > there as well? Sounds reasonable to me - requiring the

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

2022-08-23 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Makes sense to me. Maybe @hans has an opinion too. WDYT about accepting the same string for -fuse-ld= to mean "platform linker" there as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132444/new/

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

2022-08-23 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D132444#3742305 , @mstorsjo wrote: > In D132444#3742295 , @thakis wrote: > >> Do we have precedent for "platform" for this? For fuse-ld=, one is supposed >> to use `-fuse-ld=`

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

2022-08-23 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D132444#3742295 , @thakis wrote: > Do we have precedent for "platform" for this? For fuse-ld=, one is supposed > to use `-fuse-ld=` (without anything after the `=`) to get the default ld. > That's not great (...but it can't

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

2022-08-23 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Do we have precedent for "platform" for this? For fuse-ld=, one is supposed to use `-fuse-ld=` (without anything after the `=`) to get the default ld. That's not great (...but it can't collide with actual linker names, i suppose). Using "platform" (or any other

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

2022-08-23 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. mstorsjo added reviewers: phosek, thakis, hans. Herald added a project: All. mstorsjo requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. Normally, passing -rtlib=platform overrides any earlier -rtlib options, and