[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rGe09c75049854: [clangd][ObjC] Improve completions for protocols + category names (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1731 SymbolSlab::Builder ResultsBuilder; -if (Opts.Index->fuzzyFind(Req, [&](const Symbol ) { - if (includeSymbolFromIndex(Sym)) -

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman updated this revision to Diff 458724. dgoldman added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132962/new/ https://reviews.llvm.org/D132962 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1731 SymbolSlab::Builder ResultsBuilder; -if (Opts.Index->fuzzyFind(Req, [&](const Symbol ) { -

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman updated this revision to Diff 457258. dgoldman added a comment. Run clang-format again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132962/new/ https://reviews.llvm.org/D132962 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman updated this revision to Diff 457257. dgoldman added a comment. Fix strings + test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132962/new/ https://reviews.llvm.org/D132962 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:3228 + + Results = completions(R"objc( + Fo^ nit: just `completions("Fo^", ...)` Comment at:

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman updated this revision to Diff 457067. dgoldman added a comment. Run clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132962/new/ https://reviews.llvm.org/D132962 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman added a comment. In D132962#3761463 , @kadircet wrote: > can you also add test cases for the other two (filtering both for speculative > index queries/regular ones, and making sure we don't suggest symbols from > index for category names), so

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman updated this revision to Diff 457049. dgoldman added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132962/new/ https://reviews.llvm.org/D132962 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

kadircet added a comment. can you also add test cases for the other two (filtering both for speculative index queries/regular ones, and making sure we don't suggest symbols from index for category names), so that we don't regress in the future? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. - Render