Re: [PATCH] D13357: [Concepts] Add diagnostic; specializations of variable and function concepts

2015-10-12 Thread Nathan Wilson via cfe-commits
nwilson updated this revision to Diff 37099. nwilson added a comment. Moving tests to the correct file. Modifying the diagnostic id and message so it's more applicable to the checks in this Patch. Update the quoted sections of the standard as well. Use ternary operator for Partial Specialization

Re: [PATCH] D13357: [Concepts] Add diagnostic; specializations of variable and function concepts

2015-10-07 Thread Richard Smith via cfe-commits
On Wed, Oct 7, 2015 at 2:59 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > rsmith added inline comments. > > > Comment at: lib/Sema/SemaDecl.cpp:5902-5915 > @@ -5901,1 +5901,16 @@ > + > + // C++ Concepts TS [dcl.spec.concept]p7: A program shall not

Re: [PATCH] D13357: [Concepts] Add diagnostic; specializations of variable and function concepts

2015-10-07 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5902-5915 @@ -5901,1 +5901,16 @@ + + // C++ Concepts TS [dcl.spec.concept]p7: A program shall not declare [...] + // an explicit specialization, or a partial specialization of a concept + //

Re: [PATCH] D13357: [Concepts] Add diagnostic; specializations of variable and function concepts

2015-10-01 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.concept/p7.cpp:13 @@ +12,3 @@ +template concept bool FCEI() { return true; } +template concept bool FCEI(); // expected-error {{function concept cannot be explicitly

Re: [PATCH] D13357: [Concepts] Add diagnostic; specializations of variable and function concepts

2015-10-01 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.concept/p7.cpp:4 @@ +3,3 @@ +template concept bool VCEI { true }; +template concept bool VCEI; // expected-error {{variable concept cannot be explicitly instantiated}} +